MDL-57791 analytics: Remove reference to removed config var

This commit is contained in:
David Monllao 2017-06-28 09:17:56 +02:00
parent 98b2f06fe7
commit 950b1d78bd

View File

@ -35,6 +35,13 @@ defined('MOODLE_INTERNAL') || die();
*/
class no_teacher extends \core_analytics\local\indicator\binary {
/**
* Teacher role ids.
*
* @var array|null
*/
protected $teacherroleids = null;
/**
* get_name
*
@ -68,9 +75,11 @@ class no_teacher extends \core_analytics\local\indicator\binary {
$context = $this->retrieve('context', $sampleid);
$teacherroles = get_config('analytics', 'teacherroles');
$teacherroleids = explode(',', $teacherroles);
foreach ($teacherroleids as $role) {
if (is_null($this->teacherroleids)) {
$this->teacherroleids = array_keys(get_archetype_roles('editingteacher') + get_archetype_roles('teacher'));
}
foreach ($this->teacherroleids as $role) {
// We look for roles, not enrolments as a teacher assigned at category level is supposed to be a
// course teacher.
$teachers = get_role_users($role, $context, false, 'u.id', 'u.id');