mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-21 08:00:37 +01:00
Code Issues Projects Releases Wiki Activity

MDL-66076 forumreport_summary: Added missing SQL group by fields

Browse Source 
Also removed a redundant variable declaration.
This commit is contained in:
Michael Hawkins 2019-10-09 10:44:39 +08:00 committed by Jun Pataleta
parent d4d9b8c67c
commit 9523f0e040
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mod/forum/report/summary/classes/summary_table.php
View File

@ -430,7 +430,7 @@ class summary_table extends table_sql {
$this->sql->basewhere = 'e.courseid = :courseid';
$this->sql->basegroupby = 'ue.userid, e.courseid, f.id, u.id';
$this->sql->basegroupby = 'ue.userid, e.courseid, f.id, u.id, ' . $userfieldssql;
if ($this->logreader) {
$this->fill_log_summary_temp_table($this->context->id);
@ -526,7 +526,6 @@ class summary_table extends table_sql {
* @return string The complete SQL statement.
*/
protected function get_full_sql(bool $fullselect = true): string {
$selectfields = '';
$groupby = '';
$orderby = '';