mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-43675 navigation: courses branch is now recognised as expandable

Browse Source
This commit is contained in:
Sam Hemelryk 2014-01-14 12:29:36 +13:00
parent f05e25d208
commit 956e2e8a8c
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ajax/getnavbranch.php
View File

@ -112,16 +112,16 @@ try {
$html = ob_get_contents();
ob_end_clean();
} catch (Exception $e) {
die('Error: '.$e->getMessage());
throw new coding_exception('Error: '.$e->getMessage());
}
// Check if the buffer contianed anything if it did ERROR!
if (trim($html) !== '') {
die('Errors were encountered while producing the navigation branch'."\n\n\n".$html);
throw new coding_exception('Errors were encountered while producing the navigation branch'."\n\n\n".$html);
}
// Check that branch isn't empty... if it is ERROR!
if (empty($branch) || $branch->nodetype !== navigation_node::NODETYPE_BRANCH) {
die('No further information available for this branch');
if (empty($branch) || ($branch->nodetype !== navigation_node::NODETYPE_BRANCH && !$branch->isexpandable)) {
throw new coding_exception('No further information available for this branch');
}
// Prepare an XML converter for the branch

3
lib/navigationlib.php
View File

@ -2748,6 +2748,9 @@ class global_navigation_for_ajax extends global_navigation {
$this->rootnodes['site'] = $this->add_course($SITE);
$this->rootnodes['mycourses'] = $this->add(get_string('mycourses'), new moodle_url('/my'), self::TYPE_ROOTNODE, null, 'mycourses');
$this->rootnodes['courses'] = $this->add(get_string('courses'), null, self::TYPE_ROOTNODE, null, 'courses');
// The courses branch is always displayed, and is always expandable (although may be empty).
// This mimicks what is done during {@link global_navigation::initialise()}.
$this->rootnodes['courses']->isexpandable = true;
// Branchtype will be one of navigation_node::TYPE_*
switch ($this->branchtype) {