From da04fc522a6c0d4c57fcc9b38d9904814b900dad Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Fri, 17 May 2024 10:51:55 +0100
Subject: [PATCH] MDL-81949 tool_replace: prompt user for unrecognised CLI
 parameters.

---
 admin/tool/replace/cli/replace.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/admin/tool/replace/cli/replace.php b/admin/tool/replace/cli/replace.php
index b4244aa1c9a..9928c2a4857 100644
--- a/admin/tool/replace/cli/replace.php
+++ b/admin/tool/replace/cli/replace.php
@@ -57,7 +57,13 @@ list($options, $unrecognized) = cli_get_params(
     )
 );
 
-if ($options['help'] || $options['search'] === null || $options['replace'] === null) {
+if ($unrecognized) {
+    $unrecognized = implode("\n  ", $unrecognized);
+    cli_error(get_string('cliunknowoption', 'admin', $unrecognized));
+}
+
+// Ensure that user has populated both the search/replace parameters.
+if ($options['help'] || !is_string($options['search']) || !is_string($options['replace'])) {
     echo $help;
     exit(0);
 }