From 25d37fe24c18fdb8147f0f7a48e37a410b026be8 Mon Sep 17 00:00:00 2001 From: Andreas Grabs Date: Fri, 1 Feb 2013 00:25:31 +0100 Subject: [PATCH] MDL-37800 mod_feedback - item "information" does not appear correctly --- mod/feedback/item/info/lib.php | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/mod/feedback/item/info/lib.php b/mod/feedback/item/info/lib.php index a51c8f881aa..4fddadf322a 100644 --- a/mod/feedback/item/info/lib.php +++ b/mod/feedback/item/info/lib.php @@ -112,8 +112,8 @@ class feedback_item_info extends feedback_item_base { $values = feedback_get_group_values($item, $groupid, $courseid); if ($values) { $data = array(); - $datavalue = new stdClass(); foreach ($values as $value) { + $datavalue = new stdClass(); switch($presentation) { case 1: @@ -279,7 +279,12 @@ class feedback_item_info extends feedback_item_base { $requiredmark = ($item->required == 1)?'*':''; $feedback = $DB->get_record('feedback', array('id'=>$item->feedback)); - $course = $DB->get_record('course', array('id'=>$feedback->course)); + + if ($courseid = optional_param('courseid', 0, PARAM_INT)) { + $course = $DB->get_record('course', array('id'=>$courseid)); + } else { + $course = $DB->get_record('course', array('id'=>$feedback->course)); + } if ($course->id !== SITEID) { $coursecategory = $DB->get_record('course_categories', array('id'=>$course->category)); @@ -289,8 +294,13 @@ class feedback_item_info extends feedback_item_base { switch($presentation) { case 1: - $itemvalue = time(); - $itemshowvalue = userdate($itemvalue); + if ($feedback->anonymous == FEEDBACK_ANONYMOUS_YES) { + $itemvalue = 0; + $itemshowvalue = '-'; + } else { + $itemvalue = time(); + $itemshowvalue = userdate($itemvalue); + } break; case 2: $coursecontext = context_course::instance($course->id); @@ -390,7 +400,7 @@ class feedback_item_info extends feedback_item_base { } public function value_type() { - return PARAM_INT; + return PARAM_TEXT; } public function clean_input_value($value) {