mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-40626 gradebook: Prevent incorrect override with multiline feedback

Browse Source 
The quick grading option doesn't allow mutliline editing.
This commit is contained in:
Tim Lock 2013-07-11 18:03:34 +09:30 committed by Dan Poltawski
parent ffc3f5308b
commit 986c833743
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
grade/report/grader/lib.php
View File

@ -226,6 +226,10 @@ class grade_report_grader extends grade_report {
$changedgrades = true;
} else if ($datatype === 'feedback') {
// If quick grading is on, feedback needs to be compared without line breaks.
if ($this->get_pref('quickgrading')) {
$oldvalue->feedback = preg_replace("/\r\n|\r|\n/", "", $oldvalue->feedback);
}
if (($oldvalue->feedback === $postedvalue) or ($oldvalue->feedback === NULL and empty($postedvalue))) {
continue;
}