MDL-33565 setuplib: better error if you pass an object as $debuginfo

This changes makes sure the error is triggerd when the exception is
thrown, so that the problem code is in the stack-trace. Before, the
error happend in the exception hander, so you could not see the code
that caused the problem.
This commit is contained in:
Tim Hunt 2012-06-06 19:57:47 +01:00
parent 4db061680e
commit 98984c09a2

View File

@ -133,7 +133,7 @@ class moodle_exception extends Exception {
$this->module = $module;
$this->link = $link;
$this->a = $a;
$this->debuginfo = $debuginfo;
$this->debuginfo = is_null($debuginfo) ? null : (string)$debuginfo;
if (get_string_manager()->string_exists($errorcode, $module)) {
$message = get_string($errorcode, $module, $a);
@ -486,7 +486,7 @@ function get_exception_info($ex) {
$module = 'error';
$a = $ex->getMessage();
$link = '';
$debuginfo = null;
$debuginfo = '';
}
// Append the error code to the debug info to make grepping and googling easier