From 50a7bad23e3dfed78965e97cd3c960c2eba3d202 Mon Sep 17 00:00:00 2001 From: Simey Lameze Date: Thu, 7 Nov 2024 09:18:29 +0800 Subject: [PATCH] MDL-83643 behat: make manual completion scenario names unique --- mod/assign/tests/behat/assign_activity_completion.feature | 2 +- mod/book/tests/behat/book_activity_completion.feature | 2 +- mod/chat/tests/behat/chat_activity_completion.feature | 2 +- mod/data/tests/behat/data_activity_completion.feature | 2 +- mod/feedback/tests/behat/feedback_activity_completion.feature | 2 +- mod/folder/tests/behat/folder_activity_completion.feature | 2 +- mod/forum/tests/behat/forum_activity_completion.feature | 2 +- mod/glossary/tests/behat/glossary_activity_completion.feature | 2 +- mod/h5pactivity/tests/behat/h5pactivity_completion.feature | 2 +- mod/imscp/tests/behat/imscp_activity_completion.feature | 2 +- mod/lesson/tests/behat/lesson_activity_completion.feature | 2 +- mod/lti/tests/behat/lti_activity_completion.feature | 2 +- mod/page/tests/behat/page_activity_completion.feature | 4 ++-- mod/quiz/tests/behat/completion_manual.feature | 2 +- mod/scorm/tests/behat/scorm_activity_completion.feature | 2 +- mod/survey/tests/behat/survey_completion.feature | 2 +- mod/url/tests/behat/url_activity_completion.feature | 4 ++-- mod/wiki/tests/behat/wiki_activity_completion.feature | 2 +- mod/workshop/tests/behat/workshop_activity_completion.feature | 2 +- 19 files changed, 21 insertions(+), 21 deletions(-) diff --git a/mod/assign/tests/behat/assign_activity_completion.feature b/mod/assign/tests/behat/assign_activity_completion.feature index c583189796c..a277ad5c92b 100644 --- a/mod/assign/tests/behat/assign_activity_completion.feature +++ b/mod/assign/tests/behat/assign_activity_completion.feature @@ -70,7 +70,7 @@ Feature: View activity completion in the assignment activity And the manual completion button for "Music history" should exist @javascript - Scenario: Use manual completion from the activity page + Scenario: A student can manually mark the assign activity as done but a teacher cannot Given I am on the "Music history" "assign activity" page logged in as teacher1 # Teacher view. And the manual completion button for "Music history" should be disabled diff --git a/mod/book/tests/behat/book_activity_completion.feature b/mod/book/tests/behat/book_activity_completion.feature index 5795c51a863..aef186845af 100644 --- a/mod/book/tests/behat/book_activity_completion.feature +++ b/mod/book/tests/behat/book_activity_completion.feature @@ -65,7 +65,7 @@ Feature: View activity completion information in the book activity Then the "View" completion condition of "Art history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the book activity as done but a teacher cannot Given I am on the "Music history" "book activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/chat/tests/behat/chat_activity_completion.feature b/mod/chat/tests/behat/chat_activity_completion.feature index 4e6b5df7f1e..bd32f3c6185 100644 --- a/mod/chat/tests/behat/chat_activity_completion.feature +++ b/mod/chat/tests/behat/chat_activity_completion.feature @@ -37,7 +37,7 @@ Feature: View activity completion information in the chat activity Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the chat activity as done but a teacher cannot Given I log in as "teacher1" And the following "activity" exists: | activity | chat | diff --git a/mod/data/tests/behat/data_activity_completion.feature b/mod/data/tests/behat/data_activity_completion.feature index cf96a6fd24a..ac2e55e84d4 100644 --- a/mod/data/tests/behat/data_activity_completion.feature +++ b/mod/data/tests/behat/data_activity_completion.feature @@ -97,7 +97,7 @@ Feature: View activity completion in the database activity And "Vinnie Student1" user has completed "Music history" activity @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the data activity as done but a teacher cannot Given I am on the "Music history" "data activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/feedback/tests/behat/feedback_activity_completion.feature b/mod/feedback/tests/behat/feedback_activity_completion.feature index 50de075f47c..f7baf1058a8 100644 --- a/mod/feedback/tests/behat/feedback_activity_completion.feature +++ b/mod/feedback/tests/behat/feedback_activity_completion.feature @@ -52,7 +52,7 @@ Feature: View activity completion in the feedback activity And the "Submit feedback" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the feedback activity as done but a teacher cannot Given I am on the "Music history" "feedback activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/folder/tests/behat/folder_activity_completion.feature b/mod/folder/tests/behat/folder_activity_completion.feature index 04cf1332a1d..2097fc0efa6 100644 --- a/mod/folder/tests/behat/folder_activity_completion.feature +++ b/mod/folder/tests/behat/folder_activity_completion.feature @@ -37,7 +37,7 @@ Feature: View activity completion information in the folder activity Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the folder activity as done but a teacher cannot Given the following "activity" exists: | activity | folder | | course | C1 | diff --git a/mod/forum/tests/behat/forum_activity_completion.feature b/mod/forum/tests/behat/forum_activity_completion.feature index 1b566755ab1..a0f29b8d663 100644 --- a/mod/forum/tests/behat/forum_activity_completion.feature +++ b/mod/forum/tests/behat/forum_activity_completion.feature @@ -88,7 +88,7 @@ Feature: View activity completion in the forum activity And the "Receive a grade" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the forum activity as done but a teacher cannot Given I am on the "Music history" "forum activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/glossary/tests/behat/glossary_activity_completion.feature b/mod/glossary/tests/behat/glossary_activity_completion.feature index e7e8c966850..62235e94fd6 100644 --- a/mod/glossary/tests/behat/glossary_activity_completion.feature +++ b/mod/glossary/tests/behat/glossary_activity_completion.feature @@ -67,7 +67,7 @@ Feature: View activity completion in the glossary activity And the "Receive a grade" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the glossary activity as done but a teacher cannot Given I am on the "Music history" "glossary activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/h5pactivity/tests/behat/h5pactivity_completion.feature b/mod/h5pactivity/tests/behat/h5pactivity_completion.feature index 43b4c622beb..be3f0219bda 100644 --- a/mod/h5pactivity/tests/behat/h5pactivity_completion.feature +++ b/mod/h5pactivity/tests/behat/h5pactivity_completion.feature @@ -40,7 +40,7 @@ Feature: View activity completion information in the h5p activity Then the "View" completion condition of "Music history" is displayed as "done" And the "Receive a grade" completion condition of "Music history" is displayed as "done" - Scenario: Use manual completion + Scenario: A student can manually mark the h5p activity as done but a teacher cannot Given I am on the "Music history" "h5pactivity activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/imscp/tests/behat/imscp_activity_completion.feature b/mod/imscp/tests/behat/imscp_activity_completion.feature index 2d9d2bec481..54c8a79d20d 100644 --- a/mod/imscp/tests/behat/imscp_activity_completion.feature +++ b/mod/imscp/tests/behat/imscp_activity_completion.feature @@ -26,7 +26,7 @@ Feature: View activity completion information in the IMS content package activit Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the IMSCP activity as done but a teacher cannot Given the following "activities" exist: | activity | course | name | completion | packagefilepath | | imscp | C1 | Music history | 1 | mod/imscp/tests/packages/singescobasic.zip | diff --git a/mod/lesson/tests/behat/lesson_activity_completion.feature b/mod/lesson/tests/behat/lesson_activity_completion.feature index 254a666cfbc..5155940a61d 100644 --- a/mod/lesson/tests/behat/lesson_activity_completion.feature +++ b/mod/lesson/tests/behat/lesson_activity_completion.feature @@ -66,7 +66,7 @@ Feature: View activity completion in the lesson activity And the "Receive a grade" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the lesson activity as done but a teacher cannot Given I am on the "Music history" "lesson activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/lti/tests/behat/lti_activity_completion.feature b/mod/lti/tests/behat/lti_activity_completion.feature index 336c5244745..48c4557d23a 100644 --- a/mod/lti/tests/behat/lti_activity_completion.feature +++ b/mod/lti/tests/behat/lti_activity_completion.feature @@ -39,7 +39,7 @@ Feature: View activity completion information in the LTI activity And the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the LTI activity as done but a teacher cannot Given I am on the "Music history" "lti activity editing" page logged in as teacher1 And I expand all fieldsets And I set the field "Students must manually mark the activity as done" to "1" diff --git a/mod/page/tests/behat/page_activity_completion.feature b/mod/page/tests/behat/page_activity_completion.feature index c9265abdcb9..b9fcfa52d00 100644 --- a/mod/page/tests/behat/page_activity_completion.feature +++ b/mod/page/tests/behat/page_activity_completion.feature @@ -43,7 +43,7 @@ Feature: View activity completion information in the Page resource Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion as teacher + Scenario: A teacher cannot manually mark the page activity as done Given the following "activity" exists: | activity | page | | course | C1 | @@ -56,7 +56,7 @@ Feature: View activity completion information in the Page resource Then the manual completion button for "Music history" should be disabled @javascript - Scenario: Use manual completion as student + Scenario: A student can manually mark the page activity as done Given the following "activity" exists: | activity | page | | course | C1 | diff --git a/mod/quiz/tests/behat/completion_manual.feature b/mod/quiz/tests/behat/completion_manual.feature index d2f3e2c762b..4e6cfc83e79 100644 --- a/mod/quiz/tests/behat/completion_manual.feature +++ b/mod/quiz/tests/behat/completion_manual.feature @@ -30,7 +30,7 @@ Feature: Manually complete a quiz | First question | 1 | @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the quiz activity as done but a teacher cannot Given I am on the "Test quiz name" "quiz activity" page logged in as teacher1 And the manual completion button for "Test quiz name" should be disabled And I log out diff --git a/mod/scorm/tests/behat/scorm_activity_completion.feature b/mod/scorm/tests/behat/scorm_activity_completion.feature index 60577a9145e..54f83bd1361 100644 --- a/mod/scorm/tests/behat/scorm_activity_completion.feature +++ b/mod/scorm/tests/behat/scorm_activity_completion.feature @@ -117,7 +117,7 @@ Feature: View activity completion in the SCORM activity And the "Complete or pass the activity" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the scorm activity as done but a teacher cannot Given I am on the "Music history" "scorm activity" page logged in as teacher1 And I navigate to "Settings" in current page administration And I expand all fieldsets diff --git a/mod/survey/tests/behat/survey_completion.feature b/mod/survey/tests/behat/survey_completion.feature index a6abdd2b5cc..ca050a23d38 100644 --- a/mod/survey/tests/behat/survey_completion.feature +++ b/mod/survey/tests/behat/survey_completion.feature @@ -51,7 +51,7 @@ Feature: A teacher can use activity completion to track a student progress And I follow "Test survey name" And the "Submit answers" completion condition of "Test survey name" is displayed as "done" - Scenario: Use manual completion + Scenario: A student can manually mark the survey activity as done but a teacher cannot Given the following "activities" exist: | activity | name | course | idnumber | completion | | survey | Test survey name | C1 | survey1 | 1 | diff --git a/mod/url/tests/behat/url_activity_completion.feature b/mod/url/tests/behat/url_activity_completion.feature index 052c03a7e92..f9fee36be18 100644 --- a/mod/url/tests/behat/url_activity_completion.feature +++ b/mod/url/tests/behat/url_activity_completion.feature @@ -142,7 +142,7 @@ Feature: View activity completion information in the URL resource Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion with automatic URL as teacher + Scenario: A teacher cannot manually mark the url activity as done Given the following "activity" exists: | activity | url | | course | C1 | @@ -157,7 +157,7 @@ Feature: View activity completion information in the URL resource Then the manual completion button for "Music history" should be disabled @javascript - Scenario: Use manual completion with automatic URL as student + Scenario: A student can manually mark the url activity as done Given the following "activity" exists: | activity | url | | course | C1 | diff --git a/mod/wiki/tests/behat/wiki_activity_completion.feature b/mod/wiki/tests/behat/wiki_activity_completion.feature index 8946d256233..61a4228ba01 100644 --- a/mod/wiki/tests/behat/wiki_activity_completion.feature +++ b/mod/wiki/tests/behat/wiki_activity_completion.feature @@ -45,7 +45,7 @@ Feature: View activity completion information in the Wiki activity Then the "View" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the wiki activity as done but a teacher cannot Given I am on the "Music history" "wiki activity" page logged in as teacher1 And I am on the "Music history" "wiki activity editing" page And I expand all fieldsets diff --git a/mod/workshop/tests/behat/workshop_activity_completion.feature b/mod/workshop/tests/behat/workshop_activity_completion.feature index 6e504236446..f27cdfc40da 100644 --- a/mod/workshop/tests/behat/workshop_activity_completion.feature +++ b/mod/workshop/tests/behat/workshop_activity_completion.feature @@ -66,7 +66,7 @@ Feature: View activity completion information in the Workshop activity And the "Receive a grade" completion condition of "Music history" is displayed as "done" @javascript - Scenario: Use manual completion + Scenario: A student can manually mark the workshop activity as done but a teacher cannot Given I am on the "Music history" "workshop activity" page And I am on the "Music history" "workshop activity editing" page And I expand all fieldsets