mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 20:42:22 +02:00
Code Issues Projects Releases Wiki Activity

tightening up reg expressions used for submitted data a bit

Browse Source
This commit is contained in:
jamiesensei 2007-05-04 08:33:28 +00:00
parent 0c121d998a
commit 9ab3847595
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mod/quiz/edit.php
View File

@ -120,7 +120,7 @@
if (isset($_REQUEST['add']) and confirm_sesskey()) { /// Add selected questions to the current quiz
foreach ($_POST as $key => $value) { // Parse input for question ids
if (preg_match('!q([0-9]+)!', $key, $matches)) {
if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
$key = $matches[1];
quiz_add_quiz_question($key, $quiz);
}
@ -206,11 +206,11 @@
$rawgrades = $_POST;
unset($quiz->grades);
foreach ($rawgrades as $key => $value) { // Parse input for question -> grades
if (preg_match('!q([0-9]+)!', $key, $matches)) {
if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
$key = $matches[1];
$quiz->grades[$key] = $value;
quiz_update_question_instance($quiz->grades[$key], $key, $quiz->instance);
} elseif (preg_match('!q([0-9]+)!', $key, $matches)) { // Parse input for ordering info
} elseif (preg_match('!^q([0-9]+)$!', $key, $matches)) { // Parse input for ordering info
$key = $matches[1];
$questions[$value] = $oldquestions[$key];
}

4
question/editlib.php
View File

@ -434,7 +434,7 @@ function question_showbank($pageurl, $cm, $page, $perpage, $sortorder){
error(get_string('categorynoedit', 'quiz', $tocategory->name), $pageurl->out());
}
foreach ($_POST as $key => $value) { // Parse input for question ids
if (preg_match('!q([0-9]+)!', $key, $matches)) {
if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
$key = $matches[1];
if (!set_field('question', 'category', $tocategory->id, 'id', $key)) {
error('Could not update category field');
@ -477,7 +477,7 @@ function question_showbank($pageurl, $cm, $page, $perpage, $sortorder){
// an asterix in front of those that are in use
$inuse = false; // set to true if at least one of the questions is in use
foreach ($rawquestions as $key => $value) { // Parse input for question ids
if (preg_match('!q([0-9]+)!', $key, $matches)) {
if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
$key = $matches[1]; $questionlist .= $key.',';
if (record_exists('quiz_question_instances', 'question', $key) or
record_exists('question_states', 'originalquestion', $key)) {