MDL-17020 dml: native pgsql driver - fixing/improving unittests

This commit is contained in:
skodak 2008-10-27 12:01:15 +00:00
parent 935956b8c2
commit 9eb86c4a0d

View File

@ -65,12 +65,6 @@ class dml_test extends UnitTestCase {
$sqlarray = $DB->fix_sql_params($sql);
$this->assertEqual("SELECT * FROM {$DB->get_prefix()}testtable", $sqlarray[0]);
// Malformed param placeholders
$sql = "SELECT * FROM {testtable} WHERE name = ?param1";
$params = array('param1' => 'record2');
$sqlarray = $DB->fix_sql_params($sql, $params);
$this->assertEqual("SELECT * FROM {$DB->get_prefix()}testtable WHERE name = ?param1", $sqlarray[0]);
// Mixed param types (colon and dollar)
$sql = "SELECT * FROM {testtable} WHERE name = :param1, course = \$1";
$params = array('param1' => 'record1', 'param2' => 3);
@ -134,16 +128,6 @@ class dml_test extends UnitTestCase {
$this->assertTrue($e instanceof moodle_exception);
}
// Unsupported Bound params
$sql = "SELECT * FROM {testtable} WHERE name = $1, course = $2";
$params = array('first record', 1);
try {
$sqlarray = $DB->fix_sql_params($sql, $params);
$this->fail("Expecting an exception, none occurred");
} catch (Exception $e) {
$this->assertTrue($e instanceof moodle_exception);
}
// Correct named param placeholders
$sql = "SELECT * FROM {testtable} WHERE name = :name, course = :course";
$params = array('name' => 'first record', 'course' => 1);