From 9f7f01db04cc9b33486466591dcd7720eef6e48d Mon Sep 17 00:00:00 2001 From: mjollnir_ Date: Tue, 18 Apr 2006 22:47:56 +0000 Subject: [PATCH] mod/quiz/review quiz options loaded once per pageload, not once per qn. Moved loading of quiz review options from loop iterating over each qn to be displayed, to the top of the pageload. Should give efficency gains on quizes with long pages, as well as making the options available earlier in the process. Credit: Peter Bulmer peterbulmer@catalyst.net.nz --- mod/quiz/review.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/quiz/review.php b/mod/quiz/review.php index 3b7ccd31767..f601d56c5cd 100644 --- a/mod/quiz/review.php +++ b/mod/quiz/review.php @@ -38,6 +38,7 @@ require_login($course->id, false, $cm); $isteacher = isteacher($course->id); + $options = quiz_get_reviewoptions($quiz, $attempt, $isteacher); $popup = $isteacher ? 0 : $quiz->popup; // Controls whether this is shown in a javascript-protected window. if (!$isteacher) { @@ -232,7 +233,6 @@ $number++; // Just guessing that the missing question would have lenght 1 continue; } - $options = quiz_get_reviewoptions($quiz, $attempt, $isteacher); $options->validation = QUESTION_EVENTVALIDATE === $states[$i]->event; $options->history = ($isteacher and !$attempt->preview) ? 'all' : 'graded'; // Print the question