mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 18:04:43 +02:00
Code Issues Projects Releases Wiki Activity

MDL-46182 Inefficient query during Moodle upgrade on course_section table.

Browse Source 
This part of the code is changing an index on the course_sections table to be unique, for this to happen in the upgrade script the index must be deleted and then the new version added.

Before this change the following was being done:

* The index is removed
* A query to delete records that were not unique on this index is performed
* The unique version of the index is added

After this change the following happens:

* A query to delete records that were not unique on this index is performed
* The index is removed
* The unique version of the index is added

When the original index is present the query uses it, which greatly improves the execution plan.

Before the change an upgrade on a site with around 387967 course_section records the upgrade would be stuck on the delete query for many hours, after the change the time can be measured in minutes.
This commit is contained in:
Neill Magill 2014-10-03 10:27:06 +01:00
parent 6597413d41
commit a2aac5147d
1 changed files with 13 additions and 10 deletions

23
lib/db/upgrade.php

@ -358,16 +358,6 @@ function xmldb_main_upgrade($oldversion) {
if ($oldversion < 2012042300.00) {
// This change makes the course_section index unique.
// xmldb does not allow changing index uniqueness - instead we must drop
// index then add it again
$table = new xmldb_table('course_sections');
$index = new xmldb_index('course_section', XMLDB_INDEX_NOTUNIQUE, array('course', 'section'));
// Conditionally launch drop index course_section
if ($dbman->index_exists($table, $index)) {
$dbman->drop_index($table, $index);
}
// Look for any duplicate course_sections entries. There should not be
// any but on some busy systems we found a few, maybe due to previous
// bugs.
@ -389,6 +379,19 @@ function xmldb_main_upgrade($oldversion) {
$rs->close();
$transaction->allow_commit();
// XMLDB does not allow changing index uniqueness - instead we must drop
// index then add it again.
// MDL-46182: The query to make the index unique uses the index,
// so the removal of the non-unique version needs to happen after any
// data changes have been made.
$table = new xmldb_table('course_sections');
$index = new xmldb_index('course_section', XMLDB_INDEX_NOTUNIQUE, array('course', 'section'));
// Conditionally launch drop index course_section.
if ($dbman->index_exists($table, $index)) {
$dbman->drop_index($table, $index);
}
// Define index course_section (unique) to be added to course_sections
$index = new xmldb_index('course_section', XMLDB_INDEX_UNIQUE, array('course', 'section'));