From a3124b15dc18bbf68d87999ba25b4ee69e715cb8 Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Fri, 17 Aug 2018 14:21:49 +0800 Subject: [PATCH] MDL-62884 privacy: Additional fix for popper.js For a table with action menus inside a scrollable region, we need to ensure the table is at least big enough. --- theme/boost/scss/moodle/core.scss | 2 ++ theme/boost/style/moodle.css | 3 ++- theme/bootstrapbase/less/moodle/core.less | 2 ++ theme/bootstrapbase/style/moodle.css | 1 + 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/theme/boost/scss/moodle/core.scss b/theme/boost/scss/moodle/core.scss index 53e5411f775..42dee5d4dd0 100644 --- a/theme/boost/scss/moodle/core.scss +++ b/theme/boost/scss/moodle/core.scss @@ -286,8 +286,10 @@ form.popupform div { overflow: auto; } +// Minimum height required for a menu in a table inside a scrollable div. .no-overflow > .generaltable { margin-bottom: 0; + min-height: 10em; } // Accessibility features diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css index 75d8bfaff8e..c5bc71629f7 100644 --- a/theme/boost/style/moodle.css +++ b/theme/boost/style/moodle.css @@ -8999,7 +8999,8 @@ form.popupform div { overflow: auto; } .no-overflow > .generaltable { - margin-bottom: 0; } + margin-bottom: 0; + min-height: 10em; } .accesshide { position: absolute; diff --git a/theme/bootstrapbase/less/moodle/core.less b/theme/bootstrapbase/less/moodle/core.less index ed6680bce35..dea8b817706 100644 --- a/theme/bootstrapbase/less/moodle/core.less +++ b/theme/bootstrapbase/less/moodle/core.less @@ -374,8 +374,10 @@ form.popupform div { .pagelayout-report .no-overflow { overflow: visible; } +// Minimum height required for a menu in a table inside a scrollable div. .no-overflow > .generaltable { margin-bottom: 0; + min-height: 10em; } // Accessibility features diff --git a/theme/bootstrapbase/style/moodle.css b/theme/bootstrapbase/style/moodle.css index c5a4a99cf93..0412634475f 100644 --- a/theme/bootstrapbase/style/moodle.css +++ b/theme/bootstrapbase/style/moodle.css @@ -2676,6 +2676,7 @@ form.popupform div { } .no-overflow > .generaltable { margin-bottom: 0; + min-height: 10em; } .accesshide { position: absolute;