mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 06:18:28 +01:00
Code Issues Projects Releases Wiki Activity

mod-feedback MDL-16706 Removed inline JS and replaced with new PAGE methods

Browse Source
This commit is contained in:
samhemelryk 2009-06-26 07:32:52 +00:00
parent 0763ab2c65
commit a39fe289b0
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mod/feedback/analysis_course.php
View File

@ -133,17 +133,7 @@
echo '<input type="hidden" name="courseitemfilter" value="'.$courseitemfilter.'" />';
echo '<input type="hidden" name="courseitemfiltertyp" value="'.$courseitemfiltertyp.'" />';
echo '<input type="hidden" name="courseid" value="'.$courseid.'" />';
echo '<script language="javascript" type="text/javascript">
<!--
function setcourseitemfilter(item, item_typ) {
document.report.courseitemfilter.value = item;
document.report.courseitemfiltertyp.value = item_typ;
document.report.submit();
}
-->
</script>';
$PAGE->requires->js('mod/feedback/feedback.js')->asap();
$sql = 'select c.id, c.shortname from {course} c, '.
'{feedback_value} fv, {feedback_item} fi '.
'where c.id = fv.course_id and fv.item = fi.id '.

6
mod/feedback/feedback.js
View File

@ -8,4 +8,10 @@ function set_item_focus(itemid) {
function feedbackGo2delete(form) {
form.action = moodle_cfg.wwwroot+'/mod/feedback/delete_completed.php';
form.submit();
}
function setcourseitemfilter(item, item_typ) {
document.report.courseitemfilter.value = item;
document.report.courseitemfiltertyp.value = item_typ;
document.report.submit();
}