From 9c9fbb262c36f91bd18b99d516209ac79de28343 Mon Sep 17 00:00:00 2001
From: Rodrigo Mady <rodrigo.mady@gmail.com>
Date: Wed, 24 Jan 2024 17:41:48 -0300
Subject: [PATCH] MDL-80708 auth_email: Extendedusernamechars return
 get_signup_settings

---
 auth/email/classes/external.php             | 4 +---
 auth/email/tests/external/external_test.php | 9 +++++++--
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/auth/email/classes/external.php b/auth/email/classes/external.php
index d91c367360b..5115b05af0a 100644
--- a/auth/email/classes/external.php
+++ b/auth/email/classes/external.php
@@ -108,9 +108,7 @@ class auth_email_external extends external_api {
         if (!empty($CFG->country)) {
             $result['country'] = $CFG->country;
         }
-        if (!empty($CFG->extendedusernamechars)) {
-            $result['extendedusernamechars'] = $CFG->extendedusernamechars;
-        }
+        $result['extendedusernamechars'] = !empty($CFG->extendedusernamechars);
 
         if ($fields = profile_get_signup_fields()) {
             $result['profilefields'] = array();
diff --git a/auth/email/tests/external/external_test.php b/auth/email/tests/external/external_test.php
index 331896b65df..bb51a77e34b 100644
--- a/auth/email/tests/external/external_test.php
+++ b/auth/email/tests/external/external_test.php
@@ -74,7 +74,6 @@ class external_test extends externallib_advanced_testcase {
         $CFG->defaultcity = 'Bcn';
         $CFG->country = 'ES';
         $CFG->sitepolicy = 'https://moodle.org';
-        $CFG->extendedusernamechars = true;
 
         $result = auth_email_external::get_signup_settings();
         $result = \core_external\external_api::clean_returnvalue(auth_email_external::get_signup_settings_returns(), $result);
@@ -85,9 +84,10 @@ class external_test extends externallib_advanced_testcase {
         $this->assertEquals($CFG->country, $result['country']);
         $this->assertEquals($CFG->sitepolicy, $result['sitepolicy']);
         $this->assertEquals(print_password_policy(), $result['passwordpolicy']);
-        $this->assertEquals($CFG->extendedusernamechars, $result['extendedusernamechars']);
         $this->assertNotContains('recaptchachallengehash', $result);
         $this->assertNotContains('recaptchachallengeimage', $result);
+        // Check if the extended username chars is returning false when is not set.
+        $this->assertFalse($result['extendedusernamechars']);
 
         // Whip up a array with named entries to easily check against.
         $namedarray = array();
@@ -103,6 +103,11 @@ class external_test extends externallib_advanced_testcase {
 
         $this->assertEquals('text', $namedarray['frogname']['datatype']);
         $this->assertEquals('textarea', $namedarray['sometext']['datatype']);
+
+        $CFG->extendedusernamechars = true;
+        $result = auth_email_external::get_signup_settings();
+        $result = \core_external\external_api::clean_returnvalue(auth_email_external::get_signup_settings_returns(), $result);
+        $this->assertTrue($result['extendedusernamechars']);
     }
 
     /**