mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-83253 core: Ignore invalid components for deprecated cap info

Browse Source 
When checking for deprecated capabilty info, if a component is invalid,
skip loading of that component.
This commit is contained in:
Andrew Nicols 2024-09-25 20:37:12 +08:00
parent 97c2beae70
commit a5ac414521
No known key found for this signature in database
GPG Key ID: 6D1E3157C8CFBF14
2 changed files with 39 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/accesslib.php
View File

@ -2641,7 +2641,13 @@ function get_deprecated_capability_info($capabilityname) {
foreach ($allcaps as $cap) {
if (!in_array($cap['component'], $components)) {
$components[] = $cap['component'];
$defpath = core_component::get_component_directory($cap['component']).'/db/access.php';
$componentdir = core_component::get_component_directory($cap['component']);
if ($componentdir === null) {
continue;
}
$defpath = "{$componentdir}/db/access.php";
if (file_exists($defpath)) {
$deprecatedcapabilities = [];
require($defpath);

32
lib/tests/accesslib_test.php
View File

@ -2114,6 +2114,38 @@ class accesslib_test extends advanced_testcase {
];
}
/**
* Test get_deprecated_capability_info() with an invalid component.
*
* @covers get_deprecated_capability_info
*/
public function test_get_deprecated_capability_info_invalid_component(): void {
global $DB;
$this->resetAfterTest();
// Set up a fake plugin.
$this->setup_fake_plugin('access');
// Add a plugin for an unrelated fake component.
$DB->insert_record('capabilities', [
'name' => 'mod/fake:addinstance',
'captype' => 'write',
'contextlevel' => CONTEXT_COURSE,
'component' => 'mod_fake',
'riskbitmask' => 4,
]);
// Purge the cache.
cache::make('core', 'capabilities')->purge();
// For now we have deprecated fake/access:fakecapability.
$this->assertNotEmpty($DB->get_record('capabilities', ['component' => 'mod_fake']));
$info = get_deprecated_capability_info('fake/access:fakecapability');
$this->assertIsArray($info);
$this->assertDebuggingNotCalled();
}
/**
* Test that assigning a fake cap does not return.
*