mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-79274 assignfeedback_editpdf: Fix permission error in conversions

Browse Source 
This was causing the adhoc task to fail with a nopermission error, when
a user was unenrolled from a course before their assignment submission
could be converted into a pdf.

Comments from MDL-56810 indicate the correct approach is to not attempt
a conversion in those cases.
This commit is contained in:
Francis Devine 2023-09-06 16:00:30 +12:00
parent 00f0613f99
commit a77158fd96
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mod/assign/feedback/editpdf/classes/task/convert_submission.php
View File

@ -65,6 +65,15 @@ class convert_submission extends adhoc_task {
foreach ($users as $userid) {
mtrace('Converting submission for user id ' . $userid);
// If the assignment is not vieweable, we should not try to convert the documents
// for this submission, as it will cause the adhoc task to fail with a permission
// error.
//
// Comments on MDL-56810 indicate that submission conversion should not be attempted
// if the submission is not viewable due to the user not being enrolled.
if (!$assign->can_view_submission($userid)) {
continue;
}
// Note: Before MDL-71468, the scheduled task version of this
// task would stop attempting to poll the conversion after a
// configured number of attempts were made to poll it, see: