mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-69551 quiz: start quiz password field should be a passwordunmask

Browse Source 
This help accessibility and usability
This commit is contained in:
Tim Hunt 2023-03-28 17:35:21 +01:00
parent a78f3a02c6
commit aa9a462a4b
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mod/quiz/accessrule/password/rule.php
View File

@ -63,8 +63,8 @@ class quizaccess_password extends quiz_access_rule_base {
// Don't use the 'proper' field name of 'password' since that get's
// Firefox's password auto-complete over-excited.
$mform->addElement('password', 'quizpassword',
get_string('quizpassword', 'quizaccess_password'), array('autofocus' => 'true'));
$mform->addElement('passwordunmask', 'quizpassword',
get_string('quizpassword', 'quizaccess_password'), ['autofocus' => 'true']);
}
public function validate_preflight_check($data, $files, $errors, $attemptid) {

4
mod/quiz/tests/behat/attempt_begin.feature
View File

@ -80,8 +80,6 @@ Feature: The various checks that may happen when an attept is started
And I should see "Your attempt will have a time limit of 1 hour. When you "
And I should see "The password entered was incorrect"
And I set the field "Quiz password" to "Frog"
# On Mac/FF tab key is needed as text field in dialogue and page have same id.
And I press tab key in "Quiz password" "field"
And I press "Start attempt"
And I should see "Text of the first question"
@ -102,8 +100,6 @@ Feature: The various checks that may happen when an attept is started
And I should see "Your attempt will have a time limit of 1 hour. When you "
And I should see "The password entered was incorrect"
And I set the field "Quiz password" to "Frog"
# On Mac/FF tab key is needed as text field in dialogue and page have same id.
And I press tab key in "Quiz password" "field"
And I press "Cancel"
Then I should see "Quiz 1 description"
And "Attempt quiz" "button" should be visible