mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-18 22:50:19 +01:00
Code Issues Projects Releases Wiki Activity

MDL-83048 mod_quiz: Fixed use of grade_out_of and plugin renderer

Browse Source
This commit is contained in:
Wiktor Wandachowicz 2024-09-09 13:19:16 +02:00 committed by Tim Hunt
parent 3f9b9363d0
commit ab25803907
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mod/quiz/index.php
View File

@ -23,6 +23,7 @@
*/
use mod_quiz\output\grades\grade_out_of;
use mod_quiz\output\renderer;
require_once("../../config.php");
require_once("locallib.php");
@ -46,8 +47,10 @@ $strquizzes = get_string("modulenameplural", "quiz");
$PAGE->navbar->add($strquizzes);
$PAGE->set_title($strquizzes);
$PAGE->set_heading($course->fullname);
echo $OUTPUT->header();
echo $OUTPUT->heading($strquizzes, 2);
/** @var renderer $output */
$output = $PAGE->get_renderer('mod_quiz');
echo $output->header();
echo $output->heading($strquizzes, 2);
// Get all the appropriate data.
if (!$quizzes = get_all_instances_in_course("quiz", $course)) {
@ -162,8 +165,8 @@ foreach ($quizzes as $quiz) {
$feedback = '';
if ($quiz->grade && array_key_exists($quiz->id, $grades)) {
if ($alloptions->marks >= question_display_options::MARK_AND_MAX) {
$grade = $OUTPUT->render(new grade_out_of(
$grades[$quiz->id], $quiz->grade, $quiz->sumgrades, style: grade_out_of::SHORT));
$grade = $output->render(new grade_out_of(
$quiz, $grades[$quiz->id], $quiz->grade, $quiz->sumgrades, style: grade_out_of::SHORT));
}
if ($alloptions->overallfeedback) {
$feedback = quiz_feedback_for_grade($grades[$quiz->id], $quiz, $context);
@ -182,4 +185,4 @@ foreach ($quizzes as $quiz) {
echo html_writer::table($table);
// Finish the page.
echo $OUTPUT->footer();
echo $output->footer();

5
mod/quiz/tests/behat/attempt_review_options.feature
View File

@ -62,3 +62,8 @@ Feature: Allow settings to show Max marks and Marks, Max marks only, or hide the
And I should see "Question 1" in the ".info" "css_element"
And I should see "Correct" in the ".info" "css_element"
And I should see "Mark 2.00 out of 2.00" in the ".info" "css_element"
# Check the page that lists all the quizzes in a course.
And I am on the "C1" "quiz index" page
And I should see "Quiz 1"
And I should see "Quiz 2"