mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 20:50:21 +01:00
Code Issues Projects Releases Wiki Activity

improvements to generation of html from xml:

Browse Source 
JCloze: set textbox size allowing for minimum gap size setting and longest answer;
JMatch: allow for duplicates and distractors in RHS items;
JQuiz: set textbox size allowing for longest answer, and use textarea if answer longer than 29 chars;
This commit is contained in:
gbateson 2008-07-13 12:22:32 +00:00
parent ad0373df55
commit accb4c04eb
1 changed files with 62 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
mod/hotpot/template/v6.php
View File

@ -715,9 +715,14 @@ class hotpot_xml_quiz_template extends hotpot_xml_template_default {
$this->set_jmatch_items(); $this->set_jmatch_items();
$str = ''; $str = '';
foreach ($this->l_items as $i=>$item) { foreach ($this->l_items as $i=>$item) {
for ($ii=0; $ii<$i; $ii++) {
if ($this->r_items[$ii]['text']==$this->r_items[$i]['text']) {
break;
}
}
$str .= "F[$i] = new Array();\n"; $str .= "F[$i] = new Array();\n";
$str .= "F[$i][0] = '".$this->js_safe($item['text'], true)."';\n"; $str .= "F[$i][0] = '".$this->js_safe($item['text'], true)."';\n";
$str .= "F[$i][1] = ".($i+1).";\n"; $str .= "F[$i][1] = ".($ii+1).";\n";
} }
return $str; return $str;
} }
@ -725,33 +730,51 @@ class hotpot_xml_quiz_template extends hotpot_xml_template_default {
$this->set_jmatch_items(); $this->set_jmatch_items();
$str = ''; $str = '';
foreach ($this->r_items as $i=>$item) { foreach ($this->r_items as $i=>$item) {
for ($ii=0; $ii<$i; $ii++) {
if ($this->r_items[$ii]['text']==$this->r_items[$i]['text']) {
break;
}
}
$str .= "D[$i] = new Array();\n"; $str .= "D[$i] = new Array();\n";
$str .= "D[$i][0] = '".$this->js_safe($item['text'], true)."';\n"; $str .= "D[$i][0] = '".$this->js_safe($item['text'], true)."';\n";
$str .= "D[$i][1] = ".($i+1).";\n"; $str .= "D[$i][1] = ".($ii+1).";\n";
$str .= "D[$i][2] = '".$item['fixed']."';\n"; $str .= "D[$i][2] = ".$item['fixed'].";\n";
} }
return $str; return $str;
} }
function set_jmatch_items() { function set_jmatch_items() {
if (empty($this->l_items)) { if (count($this->l_items)) {
$tags = 'data,matching-exercise,pair'; return;
$i = 0; }
while (($leftitem = "[$i]['#']['left-item'][0]['#']") && $this->parent->xml_value($tags, $leftitem)) { $tags = 'data,matching-exercise,pair';
$lefttext = $this->parent->xml_value($tags, $leftitem."['text'][0]['#']"); $i = 0;
if (strlen($lefttext)) { while (($item = "[$i]['#']") && $this->parent->xml_value($tags, $item)) {
$this->l_items[] = array( $leftitem = $item."['left-item'][0]['#']";
'text' => $lefttext, $lefttext = $this->parent->xml_value($tags, $leftitem."['text'][0]['#']");
'fixed' => $this->int_value($tags, $leftitem."['fixed'][0]['#']")
); $rightitem = $item."['right-item'][0]['#']";
$rightitem = "[$i]['#']['right-item'][0]['#']"; $righttext = $this->parent->xml_value($tags, $rightitem."['text'][0]['#']");
$this->r_items[] = array(
'text' => $this->parent->xml_value($tags, $rightitem."['text'][0]['#']"), if (strlen($righttext)) {
'fixed' => $this->int_value($tags, $rightitem."['fixed'][0]['#']") $addright = true;
); } else {
} $addright = false;
$i++;
} }
if (strlen($lefttext)) {
$this->l_items[] = array(
'text' => $lefttext,
'fixed' => $this->int_value($tags, $leftitem."['fixed'][0]['#']")
);
$addright = true; // force right item to be added
}
if ($addright) {
$this->r_items[] = array(
'text' => $righttext,
'fixed' => $this->int_value($tags, $rightitem."['fixed'][0]['#']")
);
}
$i++;
} }
} }
function shuffle_jmatch_items(&$items) { function shuffle_jmatch_items(&$items) {
@ -901,7 +924,9 @@ class hotpot_xml_quiz_template extends hotpot_xml_template_default {
$gap .= '<select id="Gap'.$q.'"><option value=""></option>'.$dropdownlist.'</select>'; $gap .= '<select id="Gap'.$q.'"><option value=""></option>'.$dropdownlist.'</select>';
} else { } else {
// minimum gap size // minimum gap size
$gapsize = 6; if (! $gapsize = $this->int_value('hotpot-config-file,'.$this->parent->quiztype.',minimum-gap-size')) {
$gapsize = 6;
}
// increase gap size to length of longest answer for this gap // increase gap size to length of longest answer for this gap
$a = 0; $a = 0;
@ -1262,8 +1287,23 @@ class hotpot_xml_quiz_template extends hotpot_xml_template_default {
$question_type==HOTPOT_JQUIZ_SHORTANSWER || $question_type==HOTPOT_JQUIZ_SHORTANSWER ||
$question_type==HOTPOT_JQUIZ_HYBRID $question_type==HOTPOT_JQUIZ_HYBRID
) { ) {
$size = 9; // default size
$a = 0;
$answers = $question."['answers'][0]['#']";
while (($answer = $answers."['answer'][$a]['#']") && $this->parent->xml_value($tags, $answer)) {
$text = $this->parent->xml_value($tags, $answer."['text'][0]['#']");
$text = preg_replace('/&[#a-zA-Z0-9]+;/', 'x', $text);
$size = max($size, strlen($text));
$a++;
}
$str .= '<div class="ShortAnswer" id="Q_'.$q.'_SA"><form method="post" action="" onsubmit="return false;"><div>'; $str .= '<div class="ShortAnswer" id="Q_'.$q.'_SA"><form method="post" action="" onsubmit="return false;"><div>';
$str .= '<input type="text" id="Q_'.$q.'_Guess" onfocus="TrackFocus('."'".'Q_'.$q.'_Guess'."'".')" onblur="LeaveGap()" class="ShortAnswerBox" size="9"></input><br /><br />'; if ($size<=25) { // text box
$str .= '<input type="text" id="Q_'.$q.'_Guess" onfocus="TrackFocus('."'".'Q_'.$q.'_Guess'."'".')" onblur="LeaveGap()" class="ShortAnswerBox" size="'.$size.'"></input>';
} else { // textarea (29 cols wide)
$str .= '<textarea id="Q_'.$q.'_Guess" onfocus="TrackFocus('."'".'Q_'.$q.'_Guess'."'".')" onblur="LeaveGap()" class="ShortAnswerBox" cols="29" rows="'.ceil($size/25).'"></textarea>';
}
$str .= '<br /><br />';
$caption = $this->v6_expand_CheckCaption(); $caption = $this->v6_expand_CheckCaption();
$str .= $this->v6_expand_jquiz_button($caption, "CheckShortAnswer($q)"); $str .= $this->v6_expand_jquiz_button($caption, "CheckShortAnswer($q)");