diff --git a/lib/adminlib.php b/lib/adminlib.php index bef6e6b80ed..5deb194f7f2 100644 --- a/lib/adminlib.php +++ b/lib/adminlib.php @@ -6605,37 +6605,45 @@ class admin_setting_manageantiviruses extends admin_setting { // Iterate through auth plugins and add to the display table. $updowncount = 1; $antiviruscount = count($activeantiviruses); - $url = "antiviruses.php?sesskey=" . sesskey(); + $baseurl = new moodle_url('/admin/antiviruses.php', array('sesskey' => sesskey())); foreach ($antivirusesavailable as $antivirus => $name) { // Hide/show link. $class = ''; if (in_array($antivirus, $activeantiviruses)) { - $hideshow = ""; - $hideshow .= "pix_url('t/hide') . "\" class=\"iconsmall\" alt=\"disable\" />"; + $hideshowurl = $baseurl; + $hideshowurl->params(array('action' => 'disable', 'antivirus' => $antivirus)); + $hideshowimg = html_writer::img($OUTPUT->pix_url('t/hide'), 'disable', array('class' => 'iconsmall')); + $hideshow = html_writer::link($hideshowurl, $hideshowimg); $enabled = true; $displayname = $name; } else { - $hideshow = ""; - $hideshow .= "pix_url('t/show') . "\" class=\"iconsmall\" alt=\"enable\" />"; + $hideshowurl = $baseurl; + $hideshowurl->params(array('action' => 'enable', 'antivirus' => $antivirus)); + $hideshowimg = html_writer::img($OUTPUT->pix_url('t/show'), 'enable', array('class' => 'iconsmall')); + $hideshow = html_writer::link($hideshowurl, $hideshowimg); $enabled = false; $displayname = $name; $class = 'dimmed_text'; } - // Up/down link (only if auth is enabled). + // Up/down link. $updown = ''; if ($enabled) { if ($updowncount > 1) { - $updown .= ""; - $updown .= "pix_url('t/up') . "\" alt=\"up\" class=\"iconsmall\" /> "; + $updownurl = $baseurl; + $updownurl->params(array('action' => 'up', 'antivirus' => $antivirus)); + $updownimg = html_writer::img($OUTPUT->pix_url('t/up'), 'up', array('class' => 'iconsmall')); + $updown = html_writer::link($updownurl, $updownimg); } else { - $updown .= "pix_url('spacer') . "\" class=\"iconsmall\" alt=\"\" /> "; + $updown .= html_writer::img($OUTPUT->pix_url('spacer'), '', array('class' => 'iconsmall')); } if ($updowncount < $antiviruscount) { - $updown .= ""; - $updown .= "pix_url('t/down') . "\" alt=\"down\" class=\"iconsmall\" />"; + $updownurl = $baseurl; + $updownurl->params(array('action' => 'down', 'antivirus' => $antivirus)); + $updownimg = html_writer::img($OUTPUT->pix_url('t/down'), 'down', array('class' => 'iconsmall')); + $updown = html_writer::link($updownurl, $updownimg); } else { - $updown .= "pix_url('spacer') . "\" class=\"iconsmall\" alt=\"\" />"; + $updown .= html_writer::img($OUTPUT->pix_url('spacer'), '', array('class' => 'iconsmall')); } ++ $updowncount; } @@ -6643,7 +6651,7 @@ class admin_setting_manageantiviruses extends admin_setting { // Settings link. if (file_exists($CFG->dirroot.'/lib/antivirus/'.$antivirus.'/settings.php')) { $eurl = new moodle_url('/admin/settings.php', array('section' => 'antivirussettings'.$antivirus)); - $settings = "{$txt->settings}"; + $settings = html_writer::link($eurl, $txt->settings); } else { $settings = ''; } @@ -6661,7 +6669,7 @@ class admin_setting_manageantiviruses extends admin_setting { $table->data[] = $row; } $return .= html_writer::table($table); - $return .= get_string('configantivirusplugins', 'antivirus').'
'.get_string('tablenosave', 'admin'); + $return .= get_string('configantivirusplugins', 'antivirus') . html_writer::empty_tag('br') . get_string('tablenosave', 'admin'); $return .= $OUTPUT->box_end(); return highlight($query, $return); }