1
0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 18:04:43 +02:00

MDL-56347 caching: Better class variables for notices.

This commit is contained in:
Russell Smith 2016-10-11 15:16:14 +11:00 committed by Rajesh Taneja
parent 502b66f53d
commit ae9e735c77
No known key found for this signature in database
GPG Key ID: B363F7FB787F80E4

@ -536,6 +536,11 @@ class cache_phpunit_factory extends cache_factory {
parent::disable();
}
/**
* @var bool Whether the warning notice about alternative cache store used has been displayed.
*/
protected $altcachestorenotice = false;
/**
* Creates a store instance given its name and configuration.
*
@ -548,8 +553,6 @@ class cache_phpunit_factory extends cache_factory {
*/
public function create_store_from_config($name, array $details, cache_definition $definition) {
static $noticeshown = false;
if (isset($details['use_test_store'])) {
// name, plugin, alt
$class = 'cachestore_'.$details['plugin'];
@ -563,10 +566,10 @@ class cache_phpunit_factory extends cache_factory {
}
// Notify user that alternative store is being used, so action can be taken.
if (!$noticeshown) {
if (!$this->altcachestorenotice) {
echo PHP_EOL . "++ WARNING: " . 'Failed to use "' . $details['plugin'] . '" cache store, alt "' .
$details['alt']['plugin'] . '" cache store is used.' . PHP_EOL . PHP_EOL;
$noticeshown = true;
$this->altcachestorenotice = true;
}
$details = $details['alt'];
$details['class'] = 'cachestore_'.$details['plugin'];