mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 13:02:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-36761 core_grade:shifted a call to count() out of a loop

Browse Source
This commit is contained in:
Andrew Davis 2012-11-27 10:04:59 +08:00
parent f42c34a38a
commit aee968da79
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/grade/grade_category.php
View File

@ -886,7 +886,9 @@ class grade_category extends grade_object {
$droppedsomething = false;
$grade_keys = array_keys($grade_values);
if (count($grade_keys) === 0) {
$gradekeycount = count($grade_keys);
if ($gradekeycount === 0) {
//We've dropped all grade items
break;
}
@ -912,7 +914,7 @@ class grade_category extends grade_object {
// Now iterate over the remaining grade items
// We're looking for other grade items with the same grade value but a higher grademax
$i = 1;
while ($originalindex+$i < count($grade_keys)) {
while ($originalindex + $i < $gradekeycount) {
$possibleitemid = $grade_keys[$originalindex+$i];
$i++;