mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 04:30:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-79056 gradereport_user: Set grade category and item names as th

Browse Source 
* The table cells mentioned in the `headers` attribute of other table
cells need to be using the table header <th> tag. Otherwise, HTML
validation fails.
This commit is contained in:
Jun Pataleta 2023-08-18 23:24:35 +08:00
parent c6e727732a
commit af22c038b7
No known key found for this signature in database
GPG Key ID: F83510526D99E2C7
2 changed files with 29 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
grade/report/user/classes/report/user.php
View File

@ -1054,6 +1054,12 @@ class user extends grade_report {
if (!is_null($content)) {
$rowcell = new \html_table_cell($content);
// Grade item names and cateogry names are referenced in the `headers` attribute of table cells.
// These table cells should be set to <th> tags.
if ($tablecolumn === 'itemname') {
$rowcell->header = true;
}
if (isset($rowdata[$tablecolumn]['class'])) {
$rowcell->attributes['class'] = $rowdata[$tablecolumn]['class'];
}

37
grade/report/user/styles.css
View File

@ -67,6 +67,8 @@
.grade-report-user .user-grade .baggt,
.grade-report-user .user-grade .baggb {
font-weight: bold;
background-color: #f8f9fa;
border: none;
}
.path-grade-report-user .user-report-container,
@ -99,23 +101,30 @@
border-bottom: 1px solid #dee2e6;
}
.path-grade-report-user .user-grade td.category,
.grade-report-user .user-grade td.category {
.path-grade-report-user .user-grade th.column-itemname:not(.header,.category,.baggt,.baggb),
.grade-report-user .user-grade th.column-itemname:not(.header,.category,.baggt,.baggb) {
background-color: white;
font-weight: normal;
border-bottom: 1px solid #dee2e6;
}
.path-grade-report-user .user-grade th.category,
.grade-report-user .user-grade th.category {
background-color: white;
border: 1px solid #dee2e6;
padding-left: 10px;
font-weight: bold;
}
.path-grade-report-user .user-grade td.category a[aria-expanded="true"] .expanded,
.path-grade-report-user .user-grade td.category a[aria-expanded="false"] .collapsed,
.grade-report-user .user-grade td.category a[aria-expanded="true"] .expanded,
.grade-report-user .user-grade td.category a[aria-expanded="false"] .collapsed {
.path-grade-report-user .user-grade th.category a[aria-expanded="true"] .expanded,
.path-grade-report-user .user-grade th.category a[aria-expanded="false"] .collapsed,
.grade-report-user .user-grade th.category a[aria-expanded="true"] .expanded,
.grade-report-user .user-grade th.category a[aria-expanded="false"] .collapsed {
display: none;
}
.path-grade-report-user .user-grade td.category a.toggle-category,
.grade-report-user .user-grade td.category a.toggle-category {
.path-grade-report-user .user-grade th.category a.toggle-category,
.grade-report-user .user-grade th.category a.toggle-category {
height: 24px;
width: 24px;
font-size: 12px;
@ -123,8 +132,8 @@
margin-right: 3px;
}
.path-grade-report-user .user-grade td.category a.toggle-category i,
.grade-report-user .user-grade td.category a.toggle-category i {
.path-grade-report-user .user-grade th.category a.toggle-category i,
.grade-report-user .user-grade th.category a.toggle-category i {
font-size: 12px;
width: 12px;
height: 12px;
@ -173,14 +182,14 @@
}
@media print {
.path-grade-report-user .user-grade td.category,
.grade-report-user .user-grade td.category {
.path-grade-report-user .user-grade th.category,
.grade-report-user .user-grade th.category {
border-left: none;
border-right: none;
}
.path-grade-report-user .user-grade td.category a.toggle-category,
.grade-report-user .user-grade td.category a.toggle-category
.path-grade-report-user .user-grade th.category a.toggle-category,
.grade-report-user .user-grade th.category a.toggle-category
.path-grade-report-user #page-footer {
display: none;
}