mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-62614 Privacy: Core tag provider delete_item_tags function not work

Browse Source
This commit is contained in:
Huong Nguyen 2018-05-31 14:29:18 +07:00 committed by Zig Tan
parent 9e7c397889
commit af2e8ed947
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tag/classes/privacy/provider.php
View File

@ -166,7 +166,7 @@ class provider implements
$params['itemid'] = $itemid;
}
if ($userid) {
$params['userid'] = $userid;
$params['tiuserid'] = $userid;
}
$DB->delete_records('tag_instance', $params);
}

29
tag/tests/privacy_test.php
View File

@ -121,6 +121,35 @@ class core_tag_privacy_testcase extends provider_testcase {
$this->assertEquals($expectedtagcount, $DB->count_records('tag_instance'));
}
/**
* Test method delete_item_tags() with userid.
*/
public function test_delete_item_tags_with_userid() {
global $DB;
$this->resetAfterTest(true);
// Create a course to tag.
$course = $this->getDataGenerator()->create_course();
$context = context_course::instance($course->id);
// Create a user to perform tagging.
$user = $this->getDataGenerator()->create_user();
$this->setUser($user);
// Tag courses.
core_tag_tag::set_item_tags('core_course', 'course', $course->id, $context, ['Tag 1', 'Tag 2'], $user->id);
$expectedtagcount = $DB->count_records('tag_instance');
// Delete tags for course. Use wrong userid.
core_tag\privacy\provider::delete_item_tags($context, 'core_course', 'course', null, 1);
$this->assertEquals($expectedtagcount, $DB->count_records('tag_instance'));
$expectedtagcount -= 2;
// Delete tags for course. Use correct userid.
core_tag\privacy\provider::delete_item_tags($context, 'core_course', 'course', null, $user->id);
$this->assertEquals($expectedtagcount, $DB->count_records('tag_instance'));
}
/**
* Test method delete_item_tags_select().
*/