mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-16 14:02:32 +02:00
Code Issues Projects Releases Wiki Activity

MDL-78597 core_course: fix content item tests covering get_all cases

Browse Source 
Fixes two tests which use the lti module as an example of a core mod
implementing the 'get_all_content_items' callback. The setup of the mod
in these tests, including course and site tools, needed to be updated
in light of the removal of the 'external tool' content item.
This commit is contained in:
Jake Dallimore 2023-08-01 12:15:41 +08:00
parent 85679c47da
commit afa44dd288
No known key found for this signature in database
2 changed files with 44 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
course/tests/content_item_readonly_repository_test.php
View File

@ -78,26 +78,39 @@ class content_item_readonly_repository_test extends \advanced_testcase {
*/
public function test_find_all() {
$this->resetAfterTest();
global $DB;
// We'll compare our results to those which are course-specific.
global $DB, $CFG;
require_once($CFG->dirroot . '/mod/lti/tests/generator/lib.php');
require_once($CFG->dirroot . '/mod/lti/locallib.php');
// We'll compare our results to those which are course-specific, using mod_lti as an example.
$course = $this->getDataGenerator()->create_course();
$user = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
/** @var \mod_lti_generator $ltigenerator */
$ltigenerator = $this->getDataGenerator()->get_plugin_generator('mod_lti');
$ltigenerator->create_tool_types([
'name' => 'site tool',
'baseurl' => 'http://example.com',
'coursevisible' => LTI_COURSEVISIBLE_ACTIVITYCHOOSER,
'state' => LTI_TOOL_STATE_CONFIGURED
]);
$teacherrole = $DB->get_record('role', array('shortname' => 'editingteacher'));
assign_capability('mod/lti:addmanualinstance', CAP_PROHIBIT, $teacherrole->id, \context_course::instance($course->id));
assign_capability('mod/lti:addpreconfiguredinstance', CAP_PROHIBIT, $teacherrole->id,
\core\context\course::instance($course->id));
$cir = new content_item_readonly_repository();
$this->setUser($user); // This is needed since the underlying lti code needs the global user despite the api accepting user.
// Course specific - lti won't be returned as the user doesn't have the required cap.
// Course specific - the tool won't be returned as the user doesn't have the capability required to use preconfigured tools.
$forcourse = $cir->find_all_for_course($course, $user);
$forcourse = array_filter($forcourse, function($contentitem) {
return $contentitem->get_name() === 'lti';
return str_contains($contentitem->get_name(), 'lti_type');
});
$this->assertEmpty($forcourse);
// All - all items are returned, including lti.
// All - all items are returned, including the lti site tool.
$all = $cir->find_all();
$all = array_filter($all, function($contentitem) {
return $contentitem->get_name() === 'lti';
return str_contains($contentitem->get_name(), 'lti_type');
});
$this->assertCount(1, $all);
}

39
course/tests/services_content_item_service_test.php
View File

@ -111,28 +111,37 @@ class services_content_item_service_test extends \advanced_testcase {
$this->resetAfterTest();
global $DB;
// Create a user in a course.
// Create a user in a course and set up a site-level LTI tool, configured to display in the activity chooser.
$course = $this->getDataGenerator()->create_course();
$user = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
/** @var \mod_lti_generator $ltigenerator */
$ltigenerator = $this->getDataGenerator()->get_plugin_generator('mod_lti');
$ltigenerator->create_tool_types([
'name' => 'site tool',
'baseurl' => 'http://example.com',
'coursevisible' => LTI_COURSEVISIBLE_ACTIVITYCHOOSER,
'state' => LTI_TOOL_STATE_CONFIGURED
]);
$cis = new content_item_service(new content_item_readonly_repository());
$allcontentitems = $cis->get_all_content_items($user);
$coursecontentitems = $cis->get_content_items_for_user_in_course($user, $course);
$this->setUser($user); // This is needed since the underlying lti code needs the global user despite the api accepting user.
// The call to get_all_content_items() should return the same items as for the course,
// given the user in an editing teacher and can add manual lti instances.
$this->assertContains('lti', array_column($coursecontentitems, 'name'));
$this->assertContains('lti', array_column($allcontentitems, 'name'));
// Now removing the cap 'mod/lti:addinstance'. This will restrict those items returned by the course-specific method.
$teacherrole = $DB->get_record('role', array('shortname' => 'editingteacher'));
assign_capability('mod/lti:addinstance', CAP_PROHIBIT, $teacherrole->id, \context_course::instance($course->id));
// Verify that all items, including lti, are still returned by the get_all_content_items() call.
// given the user is an editing teacher and can add preconfigured lti instances.
$allcontentitems = $cis->get_all_content_items($user);
$coursecontentitems = $cis->get_content_items_for_user_in_course($user, $course);
$this->assertNotContains('lti', array_column($coursecontentitems, 'name'));
$this->assertContains('lti', array_column($allcontentitems, 'name'));
$this->assertContains('site tool', array_column($coursecontentitems, 'title'));
$this->assertContains('site tool', array_column($allcontentitems, 'title'));
// Now removing the cap 'mod/lti:addpreconfiguredinstance', restricting those items returned by the course-specific method.
$teacherrole = $DB->get_record('role', array('shortname' => 'editingteacher'));
assign_capability('mod/lti:addpreconfiguredinstance', CAP_PROHIBIT, $teacherrole->id,
\core\context\course::instance($course->id));
// Verify that all items, including the tool, are still returned by the get_all_content_items() call.
$allcontentitems = $cis->get_all_content_items($user);
$coursecontentitems = $cis->get_content_items_for_user_in_course($user, $course);
$this->assertNotContains('site tool', array_column($coursecontentitems, 'title'));
$this->assertContains('site tool', array_column($allcontentitems, 'title'));
}
/**