mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 06:18:28 +01:00
Code Issues Projects Releases Wiki Activity

MDL-39488 Lesson Module: Fix for "Match question throws PHP error if one or more options have not been selected "

Browse Source 
Signed-off-by: Joseph Rézeau <moodle@rezeau.org>
This commit is contained in:
Joseph Rézeau 2013-05-03 11:00:43 +02:00 committed by Rossiani Wijaya
parent 95190fda69
commit b0e9cdd45b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mod/lesson/pagetypes/matching.php
View File

@ -161,7 +161,15 @@ class lesson_page_type_matching extends lesson_page {
}
$response = $data->response;
if (!is_array($response)) {
$empty = 0;
foreach ($response as $resp) {
if ($resp != '') {
break;
} else {
$empty ++;
}
}
if ($empty == count($response)) {
$result->noanswer = true;
return $result;
}
@ -177,13 +185,13 @@ class lesson_page_type_matching extends lesson_page {
}
unset($answers[$key]);
}
// get he users exact responses for record keeping
// get the user's exact responses for record keeping
$hits = 0;
$userresponse = array();
foreach ($response as $id => $value) {
$userresponse[] = $value;
// Make sure the user's answer is exist in question's answer
if (array_key_exists($id, $answers)) {
// Make sure the user's answer exists in question's answer
if (array_key_exists($id, $answers) && $value) {
$answer = $answers[$id];
$result->studentanswer .= '<br />'.format_text($answer->answer, $answer->answerformat, $formattextdefoptions).' = '.$answers[$value]->response;
if ($id == $value) {