mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 12:40:01 +01:00
Code Issues Projects Releases Wiki Activity

MDL-77706 atto_link: Work around Mozilla bug 1906559

Browse Source 
This upstream bug prevents creation of an anchor with a hyperlink where
the content has a block-like display.

The workaround is to wrap the content in a span, set the display to
inline, call the `createLink` command on the span, move the content out
of the span, and then remove it.

This is only done for Firefox-based browsers.
This commit is contained in:
Andrew Nicols 2024-07-08 23:18:03 +08:00
parent 4197e50fec
commit b2018b2fbc
No known key found for this signature in database
GPG Key ID: 6D1E3157C8CFBF14
4 changed files with 83 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-debug.js vendored
View File

@ -317,8 +317,33 @@ Y.namespace('M.atto_link').Button = Y.Base.create('button', Y.M.editor_atto.Edit
selectednode = host.insertContentAtFocusPoint(link.get('outerHTML'));
host.setSelection(host.getSelectionFromNode(selectednode));
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
if (Y.UA.gecko > 0) {
// For Firefox / Gecko we need to wrap the selection in a span so we can surround it with an anchor.
// This relates to https://bugzilla.mozilla.org/show_bug.cgi?id=1906559.
var originalSelection = document.getSelection();
var wrapper = document.createElement('span');
wrapper.setAttribute('data-wrapper', '');
wrapper.style.display = 'inline';
var i;
for (i = 0; i < originalSelection.rangeCount; i++) {
originalSelection.getRangeAt(i).surroundContents(wrapper);
}
host.setSelection(host.getSelectionFromNode(Y.one(wrapper)));
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
var anchorNode = wrapper.parentNode;
wrapper.children.forEach(function(child) {
anchorNode.appendChild(child);
});
wrapper.remove();
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
}
// Now set the target.
selectednode = host.getSelectionParentNode();

3
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-min.js vendored
View File

File diff suppressed because one or more lines are too long

29
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button.js vendored
View File

@ -317,8 +317,33 @@ Y.namespace('M.atto_link').Button = Y.Base.create('button', Y.M.editor_atto.Edit
selectednode = host.insertContentAtFocusPoint(link.get('outerHTML'));
host.setSelection(host.getSelectionFromNode(selectednode));
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
if (Y.UA.gecko > 0) {
// For Firefox / Gecko we need to wrap the selection in a span so we can surround it with an anchor.
// This relates to https://bugzilla.mozilla.org/show_bug.cgi?id=1906559.
var originalSelection = document.getSelection();
var wrapper = document.createElement('span');
wrapper.setAttribute('data-wrapper', '');
wrapper.style.display = 'inline';
var i;
for (i = 0; i < originalSelection.rangeCount; i++) {
originalSelection.getRangeAt(i).surroundContents(wrapper);
}
host.setSelection(host.getSelectionFromNode(Y.one(wrapper)));
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
var anchorNode = wrapper.parentNode;
wrapper.children.forEach(function(child) {
anchorNode.appendChild(child);
});
wrapper.remove();
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
}
// Now set the target.
selectednode = host.getSelectionParentNode();

29
lib/editor/atto/plugins/link/yui/src/button/js/button.js vendored
View File

@ -315,8 +315,33 @@ Y.namespace('M.atto_link').Button = Y.Base.create('button', Y.M.editor_atto.Edit
selectednode = host.insertContentAtFocusPoint(link.get('outerHTML'));
host.setSelection(host.getSelectionFromNode(selectednode));
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
if (Y.UA.gecko > 0) {
// For Firefox / Gecko we need to wrap the selection in a span so we can surround it with an anchor.
// This relates to https://bugzilla.mozilla.org/show_bug.cgi?id=1906559.
var originalSelection = document.getSelection();
var wrapper = document.createElement('span');
wrapper.setAttribute('data-wrapper', '');
wrapper.style.display = 'inline';
var i;
for (i = 0; i < originalSelection.rangeCount; i++) {
originalSelection.getRangeAt(i).surroundContents(wrapper);
}
host.setSelection(host.getSelectionFromNode(Y.one(wrapper)));
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
var anchorNode = wrapper.parentNode;
wrapper.children.forEach(function(child) {
anchorNode.appendChild(child);
});
wrapper.remove();
} else {
document.execCommand('unlink', false, null);
document.execCommand('createLink', false, url);
}
// Now set the target.
selectednode = host.getSelectionParentNode();