mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-72771 core_course: Set module visibility after moving it

Browse Source 
Move a module to another section needs to update its visibility after
placing it into the new section. Otherwise an invalid database state
prevents the system to move any module with a completion rule
involving grades.
This commit is contained in:
Marc Català 2021-12-07 14:44:53 +01:00 committed by Marc Català
parent 0c63990e4f
commit b2702ccad2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
course/lib.php
View File

@ -1763,6 +1763,9 @@ function moveto_module($mod, $section, $beforemod=NULL) {
echo $OUTPUT->notification("Could not delete module from existing section");
}
// Add the module into the new section.
course_add_cm_to_section($section->course, $mod->id, $section->section, $beforemod);
// If moving to a hidden section then hide module.
if ($mod->section != $section->id) {
if (!$section->visible && $mod->visible) {
@ -1779,8 +1782,6 @@ function moveto_module($mod, $section, $beforemod=NULL) {
}
}
// Add the module into the new section.
course_add_cm_to_section($section->course, $mod->id, $section->section, $beforemod);
return $modvisible;
}