mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 06:18:28 +01:00
Code Issues Projects Releases Wiki Activity

MDL-68061 gradereport_history: Restrict per page config value to int

Browse Source
This commit is contained in:
Michael Hawkins 2020-02-27 13:16:00 +08:00
parent 37b2ee3f64
commit b34f2c75c9
3 changed files with 50 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
grade/report/history/db/upgrade.php Normal file
View File

@ -0,0 +1,47 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Grade overview report upgrade steps.
*
* @package gradereport_history
* @copyright 2020 Michael Hawkins <michaelh@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
/**
* Function to upgrade grade history report.
*
* @param int $oldversion the version we are upgrading from
* @return bool result
*/
function xmldb_gradereport_history_upgrade($oldversion) {
if ($oldversion < 2019111801) {
$perpageconfig = get_config('moodle', 'grade_report_historyperpage');
// For existing installations with a non-integer 'per page' config, update the value to the default.
if (!empty($perpageconfig) && filter_var($perpageconfig, FILTER_VALIDATE_INT) === false) {
set_config('grade_report_historyperpage', 50);
}
upgrade_plugin_savepoint(true, 2019111801, 'gradereport', 'history');
}
return true;
}

3
grade/report/history/settings.php
View File

@ -30,7 +30,8 @@ if ($ADMIN->fulltree) {
$settings->add(new admin_setting_configtext('grade_report_historyperpage',
new lang_string('historyperpage', 'gradereport_history'),
new lang_string('historyperpage_help', 'gradereport_history'),
50
50,
PARAM_INT
));
}

2
grade/report/history/version.php
View File

@ -25,6 +25,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2019111800;
$plugin->version = 2019111801;
$plugin->requires = 2019111200;
$plugin->component = 'gradereport_history';