mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 04:52:36 +02:00
Code Issues Projects Releases Wiki Activity

MDL-78527 core_completion: Fixing tests

Browse Source
This commit is contained in:
Amaia Anabitarte 2023-08-23 15:09:35 +02:00
parent d481ec3af6
commit b87b72195c
35 changed files with 213 additions and 206 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
availability/condition/completion/tests/behat/availability_completion_previous.feature
View File

@ -97,7 +97,7 @@ Feature: Confirm that availability_completion works with previous activity setti
When I open "Page2" actions menu
And I click on "Edit settings" "link" in the "Page2" activity
And I set the following fields to these values:
| Completion tracking | Do not indicate activity completion |
| None | 1 |
And I press "Save and return to course"
When I turn editing mode off
Then I should see "Not available unless: The activity Page1 is marked complete" in the "region-main" "region"
@ -197,7 +197,7 @@ Feature: Confirm that availability_completion works with previous activity setti
And I open "Page3" actions menu
And I click on "Edit settings" "link" in the "Page3" activity
And I set the following fields to these values:
| Completion tracking | Do not indicate activity completion |
| None | 1 |
And I press "Save and return to course"
When I turn editing mode off

4
blocks/completionstatus/tests/behat/block_completionstatus.feature
View File

@ -42,8 +42,8 @@ Feature: Enable Block Completion in a course
And I follow "Test page name"
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and return to course"
When I add the "Course completion status" block
And I navigate to "Course completion" in current page administration

26
blocks/completionstatus/tests/behat/block_completionstatus_activity_completion.feature
View File

@ -1,4 +1,4 @@
@block @block_completionstatus
@block @block_completionstatus @core_completion
Feature: Enable Block Completion in a course using activity completion
In order to view the completion block in a course
As a teacher
@ -27,8 +27,8 @@ Feature: Enable Block Completion in a course using activity completion
And I follow "Test page name"
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and return to course"
And I add the "Course completion status" block
And I navigate to "Course completion" in current page administration
@ -48,8 +48,8 @@ Feature: Enable Block Completion in a course using activity completion
And I follow "Test page name"
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and return to course"
And I add the "Course completion status" block
And I navigate to "Course completion" in current page administration
@ -72,10 +72,10 @@ Feature: Enable Block Completion in a course using activity completion
Given I am on the "Test assign name" "assign activity" page logged in as teacher1
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| completionusegrade | 1 |
| completionpassgrade | 1 |
| gradepass | 50 |
| Add requirements | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| gradepass | 50 |
And I press "Save and return to course"
And I am on the "Test assign name" "assign activity" page
And I follow "View all submissions"
@ -106,10 +106,10 @@ Feature: Enable Block Completion in a course using activity completion
Given I am on the "Test assign name" "assign activity" page logged in as teacher1
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| completionusegrade | 1 |
| completionpassgrade | 1 |
| gradepass | 50 |
| Add requirements | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| gradepass | 50 |
And I press "Save and return to course"
And I am on the "Test assign name" "assign activity" page
And I follow "View all submissions"

2
blocks/myoverview/tests/behat/block_myoverview_progress.feature
View File

@ -30,7 +30,7 @@ Feature: Course overview block show users their progress on courses
Given I am on the "Test choice 1" "choice activity" page logged in as teacher1
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Add requirements | 1 |
| id_completionview | 1 |
And I press "Save and return to course"
And I log out

6
completion/tests/behat/activity_completion_criteria.feature
View File

@ -31,7 +31,7 @@ Feature: Allow to mark course as completed without cron for activity completion
And I click on "Save and display" "button"
And I am on the "Test assignment name" "assign activity editing" page
And I click on "Expand all" "link" in the "region-main" "region"
And I set the field "Completion tracking" to "Show activity as complete when conditions are met"
And I set the field "Add requirements" to "1"
And I set the field "completionusegrade" to "1"
And I press "Save and return to course"
And I navigate to "Course completion" in current page administration
@ -43,7 +43,7 @@ Feature: Allow to mark course as completed without cron for activity completion
Scenario: Update course completion when student marks activity as complete
Given I am on the "Test assignment name" "assign activity editing" page logged in as teacher1
And I click on "Expand all" "link" in the "region-main" "region"
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and return to course"
When I am on the "Completion course" course page logged in as student1
And I should see "Status: Not yet started"
@ -73,7 +73,7 @@ Feature: Allow to mark course as completed without cron for activity completion
| idnumber | assign2 |
And I am on the "Test assignment name2" "assign activity editing" page logged in as admin
And I click on "Expand all" "link" in the "region-main" "region"
And I set the field "Completion tracking" to "Show activity as complete when conditions are met"
And I set the field "Add requirements" to "1"
And I set the field "completionusegrade" to "1"
And I press "Save and return to course"
And I navigate to "Course completion" in current page administration

54
completion/tests/behat/bulk_edit_activity_completion.feature
View File

@ -6,8 +6,8 @@ Feature: Allow teachers to bulk edit activity completion rules in a course.
Background:
Given the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
| fullname | shortname | category | enablecompletion |
| Course 1 | C1 | 0 | 1 |
And the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | Frist | teacher1@example.com |
@ -18,16 +18,10 @@ Feature: Allow teachers to bulk edit activity completion rules in a course.
| student1 | C1 | student |
And the following "activities" exist:
| activity | course | idnumber | name | intro | grade |
| assign | C1 | a1 | Test assignment one | Submit something! | 300 |
| assign | C1 | a2 | Test assignment two | Submit something! | 100 |
| assign | C1 | a3 | Test assignment three | Submit something! | 150 |
| assign | C1 | a4 | Test assignment four | Submit nothing! | 150 |
And I log in as "teacher1"
And I am on "Course 1" course homepage with editing mode on
And I navigate to "Settings" in current page administration
And I set the following fields to these values:
| Enable completion tracking | Yes |
And I press "Save and display"
| assign | C1 | a1 | Test assignment one | Submit something! | 30 |
| assign | C1 | a2 | Test assignment two | Submit something! | 10 |
| assign | C1 | a3 | Test assignment three | Submit something! | 15 |
| assign | C1 | a4 | Test assignment four | Submit nothing! | 15 |
And I log out
# Given I am a teacher in a course with completion tracking enabled and activities present.
@ -41,24 +35,23 @@ Feature: Allow teachers to bulk edit activity completion rules in a course.
And I click on "Test assignment one" "checkbox"
And I click on "Test assignment two" "checkbox"
And I click on "Edit" "button"
And I should see "Completion tracking"
And I should see "The changes will affect the following 2 activities or resources:"
And I select "Show activity as complete when conditions are met" from the "completion" singleselect
And I should see "Student must make a submission"
And I click on "completionview" "checkbox"
And I click on "completionusegrade" "checkbox"
And I click on "completionsubmit" "checkbox"
And I set the following fields to these values:
| Add requirements | 1 |
| View the activity | 1 |
| Make a submission | 1 |
| Receive a grade | 1 |
And I click on "Save changes" "button"
Then I should see "Changes saved"
And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Student must view this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Student must receive a grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Student must make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "View the activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Receive a grade" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Student must view this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Student must receive a grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Student must make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "View the activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Receive a grade" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
# Same conditions as above,
@ -72,17 +65,16 @@ Feature: Allow teachers to bulk edit activity completion rules in a course.
And I click on "Test assignment one" "checkbox"
And I click on "Test assignment two" "checkbox"
And I click on "Edit" "button"
And I should see "Completion tracking"
And I should see "The changes will affect the following 2 activities or resources:"
And I select "Show activity as complete when conditions are met" from the "completion" singleselect
And I should see "Student must make a submission"
And I click on "completionusegrade" "checkbox"
And I click on "completionpassgrade" "checkbox"
And I set the field "Add requirements" to "1"
And I should see "Make a submission"
And I set the field "Receive a grade" to "1"
And I set the field "Passing grade" to "1"
And I click on "Save changes" "button"
Then I should see "Changes saved"
And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Student must receive a passing grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "Passing grade" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element"
And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Student must receive a passing grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should see "Passing grade" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"
And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element"

12
completion/tests/behat/course_completion_activity_criteria.feature
View File

@ -1,4 +1,4 @@
@block @block_completionstatus @javascript
@block @block_completionstatus @core_completion @javascript
Feature: Course completion state should match completion criteria
In order to understand the configuration or status of an course's completion
As a user
@ -36,10 +36,10 @@ Feature: Course completion state should match completion criteria
And I press "Save changes"
And I am on the "Test assignment name" "assign activity editing" page
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| completionusegrade | 1 |
| completionpassgrade | 1 |
| gradepass | 70 |
| Add requirements | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| gradepass | 70 |
And I press "Save and return to course"
Scenario: Completion status show match completion criteria when passgrage condition is set.
@ -98,7 +98,7 @@ Feature: Course completion state should match completion criteria
Scenario: Completion status show match completion criteria when passgrage condition is not set.
Given I am on the "Test assignment name" "assign activity editing" page logged in as teacher1
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Add requirements | 1 |
| completionusegrade | 1 |
| completionpassgrade | 0 |
| gradepass | 70 |

108
completion/tests/behat/default_activity_completion.feature
View File

@ -29,7 +29,7 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I set the field "Course completion tertiary navigation" to "Default activity completion"
And I click on "Expand Assignment" "button"
And I set the following fields to these values:
| completion_assign | Show activity as complete when conditions are met |
| Add requirements | 1 |
| completionview_assign | 0 |
| completionusegrade_assign | 1 |
| completionsubmit_assign | 1 |
@ -40,8 +40,8 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I press "Add an activity or resource"
And I click on "Add a new Assignment" "link" in the "Add an activity or resource" "dialogue"
And I expand all fieldsets
# Completion tracking 2 = Show activity as complete when conditions are met.
And the field "Completion tracking" matches value "2"
# Completion tracking 2 = Add requirements.
And the field "Add requirements" matches value "1"
And the field "completionview" matches value "0"
And the field "completionusegrade" matches value "1"
And the field "completionsubmit" matches value "1"
@ -49,7 +49,7 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I navigate to "Settings" in current page administration
And I expand all fieldsets
# Completion tracking 0 = Do not indicate activity completion.
And the field "Completion tracking" matches value "0"
And the field "None" matches value "1"
Scenario: Edit default activity completion rules for forum
Given the following "activity" exists:
@ -62,23 +62,26 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I set the field "Course completion tertiary navigation" to "Default activity completion"
And I click on "Expand Forum" "button"
And I set the following fields to these values:
| completion_forum | Show activity as complete when conditions are met |
| completionview_forum | 0 |
# 2 = Add requeriments.
| id_completion_forum_2 | 1 |
| completionview_forum | 0 |
# 0 = Rating.
| completiongradeitemnumber_forum | 0 |
| completionpassgrade_forum | 1 |
| completionpostsenabled_forum | 1 |
| completionposts_forum | 2 |
| completionrepliesenabled_forum | 1 |
| completionreplies_forum | 3 |
| completionusegrade_forum | 1 |
| completiongradeitemnumber_forum | 0 |
# 1 = Passing grade.
| completionpassgrade_forum | 1 |
| completionpostsenabled_forum | 1 |
| completionposts_forum | 2 |
| completionrepliesenabled_forum | 1 |
| completionreplies_forum | 3 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-forum']" "css_element"
Then I should see "Changes saved"
And I am on "Course 1" course homepage with editing mode on
And I press "Add an activity or resource"
And I click on "Add a new Forum" "link" in the "Add an activity or resource" "dialogue"
And I expand all fieldsets
# Completion tracking 2 = Show activity as complete when conditions are met.
And the field "Completion tracking" matches value "2"
# Completion tracking 2 = Add requirements.
And the field "Add requirements" matches value "1"
And the field "completionview" matches value "0"
# Value 0 for completiongradeitemnumber is "Rating".
And the field "completiongradeitemnumber" matches value "0"
@ -90,8 +93,8 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
But I am on the "Test forum one" Activity page
And I navigate to "Settings" in current page administration
And I expand all fieldsets
# Completion tracking 0 = Do not indicate activity completion.
And the field "Completion tracking" matches value "0"
# None checked = Do not indicate activity completion.
And the field "None" matches value "1"
Scenario: Edit default activity completion rules for glossary
Given the following "activity" exists:
@ -104,19 +107,20 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I set the field "Course completion tertiary navigation" to "Default activity completion"
And I click on "Expand Glossary" "button"
And I set the following fields to these values:
| completion_glossary | Show activity as complete when conditions are met |
| completionview_glossary | 0 |
| completionusegrade_glossary | 1 |
| completionentriesenabled_glossary | 1 |
| completionentries_glossary | 2 |
# Add requirements = 2.
| id_completion_glossary_2 | 1 |
| completionview_glossary | 0 |
| completionusegrade_glossary | 1 |
| completionentriesenabled_glossary | 1 |
| completionentries_glossary | 2 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-glossary']" "css_element"
Then I should see "Changes saved"
And I am on "Course 1" course homepage with editing mode on
And I press "Add an activity or resource"
And I click on "Add a new Glossary" "link" in the "Add an activity or resource" "dialogue"
And I expand all fieldsets
# Completion tracking 2 = Show activity as complete when conditions are met.
And the field "Completion tracking" matches value "2"
# Completion tracking 2 = Add requirements.
And the field "Add requirements" matches value "1"
And the field "completionview" matches value "0"
And the field "completionusegrade" matches value "1"
And the field "completionentriesenabled" matches value "1"
@ -125,7 +129,7 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I navigate to "Settings" in current page administration
And I expand all fieldsets
# Completion tracking 0 = Do not indicate activity completion.
And the field "Completion tracking" matches value "0"
And the field "None" matches value "1"
Scenario: Edit default activity completion rules for several activities
Given I am on the "Course 1" course page logged in as teacher1
@ -133,30 +137,31 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I set the field "Course completion tertiary navigation" to "Default activity completion"
And I click on "Expand Assignment" "button"
And I set the following fields to these values:
| completion_assign | Show activity as complete when conditions are met |
| completionview_assign | 0 |
| completionusegrade_assign | 0 |
| completionsubmit_assign | 1 |
| id_completion_assign_2 | 1 |
| completionview_assign | 0 |
| completionusegrade_assign | 0 |
| completionsubmit_assign | 1 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-assign']" "css_element"
And I should see "Changes saved"
And I click on "Expand Forum" "button"
And I set the following fields to these values:
| completion_forum | Show activity as complete when conditions are met |
| completionview_forum | 0 |
| completionpostsenabled_forum | 1 |
| completionposts_forum | 3 |
| completiondiscussionsenabled_forum | 0 |
| completionrepliesenabled_forum | 0 |
| id_completion_forum_2 | 1 |
| completionview_forum | 0 |
| completionpostsenabled_forum | 1 |
| completionposts_forum | 3 |
| completiondiscussionsenabled_forum | 0 |
| completionrepliesenabled_forum | 0 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-forum']" "css_element"
And I should see "Changes saved"
And I click on "Expand SCORM package" "button"
And I set the following fields to these values:
| completion_scorm | Show activity as complete when conditions are met |
| completionview_scorm | 0 |
| completionscorerequired_scorm | 3 |
| completionstatusrequired_scorm[2] | 1 |
| completionstatusrequired_scorm[4] | 0 |
| completionstatusallscos_scorm | 1 |
| id_completion_scorm_2 | 1 |
| completionview_scorm | 0 |
| completionscoredisabled | 1 |
| completionscorerequired_scorm | 3 |
| completionstatusrequired_scorm[2] | 1 |
| completionstatusrequired_scorm[4] | 0 |
| completionstatusallscos_scorm | 1 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-scorm']" "css_element"
And I should see "Changes saved"
And I click on "Expand Book" "button"
@ -166,28 +171,29 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I should see "Changes saved"
And I click on "Expand Chat" "button"
And I set the following fields to these values:
| completion_chat | Students can manually mark the activity as completed |
# Students must manually mark the activity as done = 1.
| id_completion_chat_1 | 1 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-chat']" "css_element"
And I should see "Changes saved"
# Change current page and go back to "Default activity completion", to confirm the form values have been saved properly.
And I set the field "Course completion tertiary navigation" to "Course completion settings"
And I set the field "Course completion tertiary navigation" to "Default activity completion"
Then the field "completion_chat" matches value "1"
Then the field "id_completion_chat_1" matches value "1"
# Check that the rules for book, assignment and forum are still the same.
And I click on "Expand Book" "button"
And the field "completion_book" matches value "0"
And the field "id_completion_book_0" matches value "1"
And I click on "Expand Assignment" "button"
And the field "completion_assign" matches value "2"
And the field "id_completion_assign_2" matches value "1"
And the field "completionview_assign" matches value "0"
And the field "completionusegrade_assign" matches value "0"
And the field "completionsubmit_assign" matches value "1"
And the field "completion_forum" matches value "2"
And the field "id_completion_forum_2" matches value "1"
And the field "completionview_forum" matches value "0"
And the field "completionpostsenabled_forum" matches value "1"
And the field "completionposts_forum" matches value "3"
And the field "completiondiscussionsenabled_forum" matches value "0"
And the field "completionrepliesenabled_forum" matches value "0"
And the field "completion_scorm" matches value "2"
And the field "id_completion_scorm_2" matches value "1"
And the field "completionview_scorm" matches value "0"
And the field "completionscorerequired_scorm" matches value "3"
And the field "completionstatusrequired_scorm[2]" matches value "1"
@ -200,12 +206,12 @@ Feature: Allow teachers to edit the default activity completion rules in a cours
And I set the field "Course completion tertiary navigation" to "Default activity completion"
And I click on "Expand Assignment" "button"
And I set the following fields to these values:
| completion_assign | Show activity as complete when conditions are met |
| completionview_assign | 0 |
| completionusegrade_assign | 0 |
| completionsubmit_assign | 0 |
| id_completion_assign_2 | 1 |
| completionview_assign | 0 |
| completionusegrade_assign | 0 |
| completionsubmit_assign | 0 |
And I click on "Save changes" "button" in the "[data-region='activitycompletion-assign']" "css_element"
Then I should see "When you select automatic completion, you must also enable at least one requirement (below)."
Then I should see "You must select at least one condition"
And I should not see "Changes saved"
Scenario: Activities in Default activity completion are ordered alphabetically

2
completion/tests/behat/enable_manual_complete_mark.feature
View File

@ -28,7 +28,7 @@ Feature: Allow students to manually mark an activity as complete
And I press "Save and display"
And I am on the "Test forum name" "forum activity editing" page
And I set the following fields to these values:
| completion | 1 |
| Students must manually mark the activity as done | 1 |
And I press "Save and return to course"
And "Student First" user has not completed "Test forum name" activity
And I am on the "Course 1" course page logged in as student1

8
course/tests/behat/activities_edit_completion.feature
View File

@ -1,4 +1,4 @@
@core @core_course
@core @core_course @core_completion
Feature: Edit completion settings of an activity
In order to edit completion settings without accidentally breaking user data
As a teacher
@ -15,7 +15,7 @@ Feature: Edit completion settings of an activity
Scenario: Completion is not locked when the activity has not yet been viewed
Given I am on the TestPage "Page Activity editing" page logged in as admin
When I expand all fieldsets
Then I should see "Completion tracking"
Then I should see "Completion conditions"
And I should not see "Completion options locked"
Scenario: Completion is locked after the activity has been viewed
@ -32,11 +32,11 @@ Feature: Edit completion settings of an activity
And I press "Unlock completion settings"
And I expand all fieldsets
Then I should see "Completion options unlocked"
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
And I navigate to "Settings" in current page administration
And I expand all fieldsets
Then the field "Completion tracking" matches value "Students can manually mark the activity as completed"
Then the field "Students must manually mark the activity as done" matches value "1"
@javascript
Scenario: Even when completion is locked, the user can still set the date

6
course/tests/behat/activity_navigation_with_restrictions.feature
View File

@ -28,10 +28,10 @@ Feature: Activity navigation involving activities with access restrictions
And I open "Page 2" actions menu
And I click on "Edit settings" "link" in the "Page 2" activity
And I expand all fieldsets
And I set the field "Completion tracking" to "Show activity as complete when conditions are met"
And I set the field "Add requirements" to "1"
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and return to course"
# Require Page 2 to be completed first before Page 3 can be accessed.
And I open "Page 3" actions menu

2
lib/tests/behat/alpha_chooser.feature
View File

@ -254,7 +254,7 @@ Feature: Initials bar
| assign | C1 | assign1 | TestAssignment | Test assignment description | 0 | 0 |
And I am on the "assign1" "assign Activity editing" page logged in as "admin"
And I expand all fieldsets
And I set the field "Completion tracking" to "1"
And I set the field "Students must manually mark the activity as done" to "1"
And I click on "Save and return to course" "button"
And I navigate to "Course completion" in current page administration
And I expand all fieldsets

8
mod/assign/tests/behat/assign_activity_completion.feature
View File

@ -85,8 +85,8 @@ Feature: View activity completion in the assignment activity
Given I am on the "Music history" "assign activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
| completionusegrade | 1 |
| completionsubmit | 1 |
And I press "Save and display"
@ -100,8 +100,8 @@ Feature: View activity completion in the assignment activity
And I expand all fieldsets
And I set the following fields to these values:
| assignsubmission_onlinetext_enabled | 1 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
| completionusegrade | 1 |
| completionsubmit | 1 |
And I press "Save and display"

6
mod/bigbluebuttonbn/tests/behat/completion.feature
View File

@ -22,8 +22,8 @@ Feature: As a user I can complete a BigblueButtonBN activity by usual or custom
And I click on "Settings" "link"
And I expand all fieldsets
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and display"
And I log out
Given I am on the "RoomRecordings" "bigbluebuttonbn activity" page logged in as traverst
@ -37,7 +37,7 @@ Feature: As a user I can complete a BigblueButtonBN activity by usual or custom
And I click on "Settings" "link"
And I expand all fieldsets
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Add requirements | 1 |
| Chats | 1 |
And I press "Save and display"
# We start the meeting here so to make sure that meta_analytics-callback-url is set.

2
mod/book/tests/behat/book_activity_completion.feature
View File

@ -68,7 +68,7 @@ Feature: View activity completion information in the book activity
Scenario: Use manual completion
Given I am on the "Music history" "book activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
And I set the following fields to these values:
| Chapter title | Drum theory |

15
mod/data/tests/behat/data_activity_completion.feature
View File

@ -27,12 +27,13 @@ Feature: View activity completion in the database activity
Given I am on the "Music history" "data activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the following fields to these values:
| Aggregate type | Average of ratings |
| scale[modgrade_type] | Point |
| scale[modgrade_point] | 100 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | 1 |
| Aggregate type | Average of ratings |
| scale[modgrade_type] | Point |
| scale[modgrade_point] | 100 |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| Any grade | 1 |
And I press "Save and display"
And I add a "Short text" field to "Music history" database and I fill the form with:
| Field name | Instrument types |
@ -91,7 +92,7 @@ Feature: View activity completion in the database activity
Scenario: Use manual completion
Given I am on the "Music history" "data activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

8
mod/data/tests/behat/data_activity_completion_pass_grade.feature
View File

@ -41,10 +41,10 @@ Feature: Completion pass grade
| scale[modgrade_type] | Point |
| scale[modgrade_point] | 100 |
| gradepass | 50 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | 1 |
| completionpassgrade | 1 |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| completionentriesenabled | 1 |
| completionentries | 2 |
And I press "Save and display"

2
mod/feedback/tests/behat/feedback_activity_completion.feature
View File

@ -55,7 +55,7 @@ Feature: View activity completion in the feedback activity
Scenario: Use manual completion
Given I am on the "Music history" "feedback activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

25
mod/forum/tests/behat/forum_activity_completion.feature
View File

@ -24,18 +24,21 @@ Feature: View activity completion in the forum activity
And I am on the "Music history" "forum activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the following fields to these values:
| Whole forum grading > Type | Point |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | Whole forum |
| completionpostsenabled | 1 |
| completionposts | 2 |
| completiondiscussionsenabled | 1 |
| completiondiscussions | 1 |
| completionrepliesenabled | 1 |
| completionreplies | 1 |
| Whole forum grading > Type | Point |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| completiongradeitemnumber | Whole forum |
| Any grade | 1 |
| completionpostsenabled | 1 |
| completionposts | 2 |
| completiondiscussionsenabled | 1 |
| completiondiscussions | 1 |
| completionrepliesenabled | 1 |
| completionreplies | 1 |
And I press "Save and display"
@javascript
Scenario: View automatic completion items as a teacher
When I am on the "Music history" "forum activity" page logged in as teacher1
Then "Music history" should have the "View" completion condition
@ -88,7 +91,7 @@ Feature: View activity completion in the forum activity
Scenario: Use manual completion
Given I am on the "Music history" "forum activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

25
mod/forum/tests/behat/forum_activity_completion_pass_grade.feature
View File

@ -31,18 +31,19 @@ Feature: Completion pass grade view activity completion in the forum activity
And I am on the "Music history" "forum activity editing" page
And I expand all fieldsets
And I set the following fields to these values:
| Whole forum grading > Type | Point |
| Whole forum grading > Grade to pass | 50 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | Whole forum |
| completionpostsenabled | 1 |
| completionpassgrade | 1 |
| completionposts | 2 |
| completiondiscussionsenabled | 1 |
| completiondiscussions | 1 |
| completionrepliesenabled | 1 |
| completionreplies | 1 |
| Whole forum grading > Type | Point |
| Whole forum grading > Grade to pass | 50 |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| completiongradeitemnumber | Whole forum |
| completionpostsenabled | 1 |
| completionposts | 2 |
| completiondiscussionsenabled | 1 |
| completiondiscussions | 1 |
| completionrepliesenabled | 1 |
| completionreplies | 1 |
And I press "Save and display"
Scenario: View automatic completion items as a teacher

9
mod/glossary/tests/behat/glossary_activity_completion.feature
View File

@ -27,9 +27,10 @@ Feature: View activity completion in the glossary activity
| Aggregate type | Average of ratings |
| scale[modgrade_type] | Point |
| scale[modgrade_point] | 100 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | 1 |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| Any grade | 1 |
| completionentriesenabled | 1 |
| completionentries | 1 |
And I press "Save and display"
@ -69,7 +70,7 @@ Feature: View activity completion in the glossary activity
Scenario: Use manual completion
Given I am on the "Music history" "glossary activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

8
mod/glossary/tests/behat/glossary_activity_completion_pass_grade.feature
View File

@ -39,10 +39,10 @@ Feature: Pass grade completion in the glossary activity
| scale[modgrade_type] | Point |
| scale[modgrade_point] | 100 |
| Ratings > Grade to pass | 50 |
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Require grade | 1 |
| completionpassgrade | 1 |
| Add requirements | 1 |
| View the activity | 1 |
| Receive a grade | 1 |
| Passing grade | 1 |
| completionentriesenabled | 1 |
| completionentries | 1 |
And I press "Save and display"

2
mod/h5pactivity/tests/behat/h5pactivity_completion.feature
View File

@ -42,7 +42,7 @@ Feature: View activity completion information in the h5p activity
Scenario: Use manual completion
Given I am on the "Music history" "h5pactivity activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And I am on the "Music history" "h5pactivity activity" page

2
mod/lesson/tests/behat/completion_condition_end_reached.feature
View File

@ -29,7 +29,7 @@ Feature: Set end of lesson reached as a completion condition for a lesson
And I press "Save and display"
And I am on the "Test lesson" "lesson activity editing" page
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Add requirements | 1 |
| completionview | 0 |
| completionendreached | 1 |
And I press "Save and display"

2
mod/lesson/tests/behat/completion_condition_time_spent.feature
View File

@ -28,7 +28,7 @@ Feature: Set time spent as a completion condition for a lesson
And I press "Save and display"
And I am on the "Test lesson" "lesson activity editing" page
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Add requirements | 1 |
| completionview | 0 |
| completiontimespentenabled | 1 |
| completiontimespent[timeunit] | 1 |

2
mod/lesson/tests/behat/lesson_activity_completion.feature
View File

@ -77,7 +77,7 @@ Feature: View activity completion in the lesson activity
Scenario: Use manual completion
Given I am on the "Music history" "lesson activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

4
mod/lesson/tests/lib_test.php
View File

@ -774,8 +774,8 @@ class lib_test extends \advanced_testcase {
$moddefaults->completion = 2;
$activeruledescriptions = [
get_string('completionendreached', 'lesson'),
get_string('completiontimespentgroup', 'lesson', format_time(3600)),
get_string('completionendreached_desc', 'lesson'),
get_string('completiontimespentdesc', 'lesson', format_time(3600)),
];
$this->assertEquals(mod_lesson_get_completion_active_rule_descriptions($cm1), $activeruledescriptions);
$this->assertEquals(mod_lesson_get_completion_active_rule_descriptions($cm2), []);

2
mod/lti/tests/behat/lti_activity_completion.feature
View File

@ -42,7 +42,7 @@ Feature: View activity completion information in the LTI activity
Scenario: Use manual completion
Given I am on the "Music history" "lti activity editing" page logged in as teacher1
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

33
mod/quiz/tests/behat/completion_condition_passing_grade.feature
View File

@ -66,25 +66,26 @@ Feature: Set a quiz to be marked complete when the student passes
When I am on the "ohgrades" "quiz activity editing" page logged in as "teacher1"
And I expand all fieldsets
And I set the field "Grade to pass" to "<gradepass>"
And I set the field "completionusegrade" to "1"
And I set the field "completionpassgrade" to "<completionpassgrade>"
And I set the field "Add requirements" to "1"
And I set the field "Receive a grade" to "1"
And I set the field "<completionpassgrade>" to "1"
And I press "Save and display"
Then I should see "<seen>"
And I should not see "<notseen>"
Examples:
| gradepass | completionpassgrade | decsep | seen | notseen | outcome |
| | 0 | . | method: Highest | Save and display | ok |
| | 1 | . | does not have a valid | method: Highest | completion-err |
| 0 | 0 | . | method: Highest | Save and display | ok |
| 0 | 1 | . | does not have a valid | method: Highest | completion-err |
| aaa | 0 | . | must enter a number | method: Highest | number-err |
| aaa | 1 | . | must enter a number | method: Highest | number-err |
| 200 | 0 | . | can not be greater | method: Highest | grade-big-err |
| 200 | 1 | . | can not be greater | method: Highest | grade-big-err |
| 5.55 | 0 | . | 5.55 out of 100 | Save and display | ok |
| 5.55 | 1 | . | 5.55 out of 100 | Save and display | ok |
| 5#55 | 0 | . | must enter a number | method: Highest | number-err |
| 5#55 | 1 | . | must enter a number | method: Highest | number-err |
| 5#55 | 0 | # | 5#55 out of 100 | Save and display | ok |
| 5#55 | 1 | # | 5#55 out of 100 | Save and display | ok |
| | Any grade | . | method: Highest | Save and display | ok |
| | Passing grade | . | does not have a valid | method: Highest | completion-err |
| 0 | Any grade | . | method: Highest | Save and display | ok |
| 0 | Passing grade | . | does not have a valid | method: Highest | completion-err |
| aaa | Any grade | . | must enter a number | method: Highest | number-err |
| aaa | Passing grade | . | must enter a number | method: Highest | number-err |
| 200 | Any grade | . | can not be greater | method: Highest | grade-big-err |
| 200 | Passing grade | . | can not be greater | method: Highest | grade-big-err |
| 5.55 | Any grade | . | 5.55 out of 100 | Save and display | ok |
| 5.55 | Passing grade | . | 5.55 out of 100 | Save and display | ok |
| 5#55 | Any grade | . | must enter a number | method: Highest | number-err |
| 5#55 | Passing grade | . | must enter a number | method: Highest | number-err |
| 5#55 | Any grade | # | 5#55 out of 100 | Save and display | ok |
| 5#55 | Passing grade | # | 5#55 out of 100 | Save and display | ok |

6
mod/resource/tests/behat/resource_activity_completion.feature
View File

@ -60,7 +60,7 @@ Feature: View activity completion information for file resources
And I press "Save and display"
And I am on the "Myfile" "resource activity editing" page
And I set the following fields to these values:
| Completion tracking | Students can manually mark the activity as completed |
| Students must manually mark the activity as done | 1 |
And I click on "Save and return to course" "button"
# Teacher view.
And "Myfile" should have the "Mark as done" completion condition
@ -86,8 +86,8 @@ Feature: View activity completion information for file resources
And I press "Save and display"
And I am on the "Myfile" "resource activity editing" page
And I set the following fields to these values:
| Completion tracking | Show activity as complete when conditions are met |
| Require view | 1 |
| Add requirements | 1 |
| View the activity | 1 |
And I press "Save and display"
# Teacher view.
And I am on the "Myfile" "resource activity" page

4
mod/scorm/tests/behat/completion_condition_require_status.feature
View File

@ -24,7 +24,7 @@ Feature: Scorm multi-sco completion
| course | C1 |
| name | Basic Multi-sco SCORM package |
| completion | 2 |
# Show activity as complete when conditions are met
# Add requirements
| completionstatusallscos | 0 |
| packagefilepath | mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip |
| completionstatusrequired | 4 |
@ -49,7 +49,7 @@ Feature: Scorm multi-sco completion
| course | C1 |
| name | ADV Multi-sco SCORM package |
| completion | 2 |
# Show activity as complete when conditions are met
# Add requirements
| packagefilepath | mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip |
| completionstatusallscos | 1 |
And I am on the "ADV Multi-sco SCORM package" "scorm activity" page logged in as student1

4
mod/scorm/tests/behat/scorm_activity_completion.feature
View File

@ -22,7 +22,7 @@ Feature: View activity completion in the SCORM activity
| name | Music history |
| completion | 2 |
| completionstatusallscos | 0 |
# Show activity as complete when conditions are met
# Add requirements
| packagefilepath | mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12-mini.zip |
| completionstatusrequired | 6 |
| completionscorerequired | 3 |
@ -112,7 +112,7 @@ Feature: View activity completion in the SCORM activity
Given I am on the "Music history" "scorm activity" page logged in as teacher1
And I navigate to "Settings" in current page administration
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

2
mod/wiki/tests/behat/wiki_activity_completion.feature
View File

@ -51,7 +51,7 @@ Feature: View activity completion information in the Wiki activity
And I expand all fieldsets
And I press "Unlock completion settings"
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view.
And the manual completion button for "Music history" should be disabled

5
mod/workshop/tests/behat/workshop_activity_completion.feature
View File

@ -23,7 +23,8 @@ Feature: View activity completion information in the Workshop activity
| workshop | Music history | C1 | 1 | 2 | 1 |
And I am on the "Music history" "workshop activity editing" page logged in as teacher1
And I set the following fields to these values:
| Require grade | Submission |
| Receive a grade | Submission |
| Any grade | 1 |
And I press "Save and return to course"
And I edit assessment form in workshop "Music history" as:
| id_description__idx_0_editor | Aspect1 |
@ -69,7 +70,7 @@ Feature: View activity completion information in the Workshop activity
Given I am on the "Music history" "workshop activity" page
And I am on the "Music history" "workshop activity editing" page
And I expand all fieldsets
And I set the field "Completion tracking" to "Students can manually mark the activity as completed"
And I set the field "Students must manually mark the activity as done" to "1"
And I press "Save and display"
# Teacher view
And the manual completion button for "Music history" should be disabled

9
mod/workshop/tests/behat/workshop_edit_form.feature
View File

@ -24,10 +24,11 @@ Feature: Workshop assessment with grade to pass
And I add a "Workshop" to section "0"
And I expand all fieldsets
When I set the following fields to these values:
| Workshop name | Test workshop |
| Completion tracking | Show activity as complete when conditions are met |
| Require grade | Assessment |
| completionpassgrade | 1 |
| Workshop name | Test workshop |
| Add requirements | 1 |
| Receive a grade | 1 |
| completiongradeitemnumber | Assessment |
| Passing grade | 1 |
And I press "Save and display"
And I should see "This activity does not have a valid grade to pass set. It may be set in the Grade section of the activity settings."
And I set the field "Assessment grade to pass" to ""