mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-19 23:20:09 +01:00
Code Issues Projects Releases Wiki Activity

MDL-79422 ajax: Allow no-login WS calls to fetch after a failure

Browse Source
This commit is contained in:
Andrew Nicols 2023-09-20 13:59:57 +08:00
parent 8e931f2073
commit b8f45d20fd
No known key found for this signature in database
GPG Key ID: 6D1E3157C8CFBF14
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/ajax/service.php
View File

@ -80,10 +80,26 @@ foreach ($requests as $request) {
$response = external_api::call_external_function($methodname, $args, true);
$responses[$index] = $response;
if ($response['error']) {
// Do not process the remaining requests.
$haserror = true;
break;
if (!NO_MOODLE_COOKIES) {
// If there was an error, and this HTTP request includes a Moodle cookie (and therefore a login), reject all
// subsequent changes.
//
// The reason for this is that an earlier step may be performing a dependant action. Consider the following:
// 1) Backup a thing
// 2) Reset the thing to its initial state
// 3) Restore the thing from the backup made in step 1.
//
// In the above example you do not want steps 2 and 3 to happen if step 1 fails.
// Do not process the remaining requests.
// If the request came through service-nologin.php which does not allow any kind of login,
// then it is not possible to make changes to the DB, session, site, etc.
// For all other cases, we *MUST* stop processing subsequent requests.
break;
}
}
}