mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-30 03:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-25805 Roles propagated ugly hack for parent seeing child activities into navigation lib to display nav node.

Browse Source
This commit is contained in:
Aparup Banerjee 2011-04-15 18:04:45 +08:00
parent 4452ed6f17
commit b9bcad24db
4 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
course/user.php
View File

@ -152,6 +152,7 @@ if ($course->id != SITEID && has_capability('moodle/course:viewparticipants', $c
}
$PAGE->navigation->extend_for_user($user);
$PAGE->navigation->set_userid_for_parent_nav_hack($user->id); // see MDL-25805 for reasons and for full commit reference for reversal when fixed.
$PAGE->set_title("$course->shortname: $stractivityreport ($mode)");
$PAGE->set_heading($course->fullname);
echo $OUTPUT->header();

39
lib/navigationlib.php
View File

@ -829,6 +829,8 @@ class global_navigation extends navigation_node {
protected $addedcourses = array();
/** @var int */
protected $expansionlimit = 0;
/** @var int */
protected $uglyunsupportedparenthack_userid = 0;
/**
* Constructs a new global navigation
@ -875,6 +877,19 @@ class global_navigation extends navigation_node {
}
}
/**
* Mutator to set userid to allow parent to see child's profile
* page navigation. See MDL-25805 for initial issue. Linked to it
* is an issue explaining why this is a REALLY UGLY HACK thats not
* for you to use!
*
* @param int $userid userid of profile page that parent wants to navigate around.
*/
public function set_userid_for_parent_nav_hack($userid) {
$this->uglyunsupportedparenthack_userid = $userid;
}
/**
* Initialises the navigation object.
*
@ -986,12 +1001,28 @@ class global_navigation extends navigation_node {
// If the user is not enrolled then we only want to show the
// course node and not populate it.
$coursecontext = get_context_instance(CONTEXT_COURSE, $course->id);
// Not enrolled, can't view, and hasn't switched roles
// Not enrolled, can't view, and hasn't switched roles
if (!can_access_course($coursecontext)) {
$coursenode->make_active();
$canviewcourseprofile = false;
break;
// TODO: very ugly hack - do not force "parents" to enrol into course their child is enrolled in,
// this hack has been propagated from user/view.php to display the navigation node. (MDL-25805)
$isparent = false;
if ($this->uglyunsupportedparenthack_userid) {
$currentuser = ($this->uglyunsupportedparenthack_userid == $USER->id);
if (!$currentuser) {
$usercontext = get_context_instance(CONTEXT_USER, $this->uglyunsupportedparenthack_userid, MUST_EXIST);
if ($DB->record_exists('role_assignments', array('userid'=>$USER->id, 'contextid'=>$usercontext->id))
and has_capability('moodle/user:viewdetails', $usercontext)) {
$isparent = true;
}
}
}
if (!$isparent) {
$coursenode->make_active();
$canviewcourseprofile = false;
break;
}
}
// Add the essentials such as reports etc...
$this->add_course_essentials($coursenode, $course);

1
mod/forum/user.php
View File

@ -86,6 +86,7 @@ if (has_capability('moodle/course:viewparticipants', get_context_instance(CONTEX
}
$PAGE->navigation->extend_for_user($user);
$PAGE->navigation->set_userid_for_parent_nav_hack($id); // see MDL-25805 for reasons and for full commit reference for reversal when fixed.
$PAGE->set_title("$course->shortname: $fullname: $strmode");
$PAGE->set_heading($course->fullname);
echo $OUTPUT->header();

1
user/view.php
View File

@ -80,6 +80,7 @@ if (!$currentuser
// please note this is just a guess!
require_login();
$isparent = true;
$PAGE->navigation->set_userid_for_parent_nav_hack($id);
} else {
// normal course
require_login($course);