mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-39390 delete old moodle_database column cache

Browse Source 
With MDL-39389 all the remaining drivers have been moved
from the in-memory, per-request ::columns cache to
the MUC (databasemeta) alternative.

That makes the old cache unused, so this is, simply about to
delete it, and warn in upgrade notes for potential sites
using custom moodle_database drivers.
This commit is contained in:
Eloy Lafuente (stronk7) 2013-04-28 18:33:33 +02:00
parent cf5a3296c4
commit bae2846c2c
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dml/moodle_database.php
View File

@ -66,8 +66,6 @@ abstract class moodle_database {
protected $database_manager;
/** @var moodle_temptables temptables manager to provide cross-db support for temp tables. */
protected $temptables;
/** @var array Cache of column info. */
protected $columns = array(); // I wish we had a shared memory cache for this :-(
/** @var array Cache of table info. */
protected $tables = null;
@ -356,7 +354,6 @@ abstract class moodle_database {
$this->database_manager->dispose();
$this->database_manager = null;
}
$this->columns = array();
$this->tables = null;
}
@ -945,7 +942,6 @@ abstract class moodle_database {
* @return void
*/
public function reset_caches() {
$this->columns = array();
$this->tables = null;
// Purge MUC as well
$identifiers = array('dbfamily' => $this->get_dbfamily(), 'settings' => $this->get_settings_hash());

3
lib/upgrade.txt
View File

@ -3,6 +3,9 @@ information provided here is intended especially for developers.
=== 2.5 ===
* The database drivers (moodle_database and subclasses) aren't using anymore the ::columns property
for caching database metadata. MUC (databasemeta) is used instead. Any custom DB driver should
apply for that change.
* The cron output has been changed to include time and memory usage (see cron_trace_time_and_memory()),
so any custom utility relying on the old output may require modification.
* Function get_max_file_sizes now returns an option for (for example) "Course limit (500MB)" or