From f6d94dc01f6731d531af63f813f69b2b372ebeec Mon Sep 17 00:00:00 2001
From: Cameron Ball <cameron@moodle.com>
Date: Wed, 14 Dec 2016 14:03:59 +0800
Subject: [PATCH 1/4] MDL-57321 theme_boost: Consistently apply attributes on
 elements

---
 admin/templates/setting_configtext.mustache             | 2 +-
 lib/templates/action_link.mustache                      | 4 ++--
 lib/templates/action_menu.mustache                      | 6 +++---
 lib/templates/action_menu_link.mustache                 | 2 +-
 lib/templates/pix_icon.mustache                         | 2 +-
 lib/templates/select_time.mustache                      | 2 +-
 lib/templates/single_select.mustache                    | 2 +-
 lib/templates/url_select.mustache                       | 2 +-
 theme/boost/templates/core/action_menu.mustache         | 4 ++--
 theme/boost/templates/core/action_menu_link.mustache    | 2 +-
 theme/boost/templates/core/action_menu_trigger.mustache | 4 ++--
 theme/boost/templates/core/pix_icon.mustache            | 2 +-
 theme/boost/templates/core/select_time.mustache         | 2 +-
 13 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/admin/templates/setting_configtext.mustache b/admin/templates/setting_configtext.mustache
index 15fd9680d94..236228a7922 100644
--- a/admin/templates/setting_configtext.mustache
+++ b/admin/templates/setting_configtext.mustache
@@ -38,5 +38,5 @@
     }
 }}
 <div class="form-text defaultsnext">
-    <input type="text" name="{{name}}" value="{{value}}" size="{{size}}" id="{{id}}" class="{{#forceltr}}text-ltr{{/forceltr}}" {{#attributes}} {{name}}="{{value}}"{{/attributes}}>
+    <input type="text" name="{{name}}" value="{{value}}" size="{{size}}" id="{{id}}" class="{{#forceltr}}text-ltr{{/forceltr}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
 </div>
diff --git a/lib/templates/action_link.mustache b/lib/templates/action_link.mustache
index 04284afa896..11617bc1761 100644
--- a/lib/templates/action_link.mustache
+++ b/lib/templates/action_link.mustache
@@ -52,11 +52,11 @@
     }
 }}
 {{^disabled}}
-    <a href="{{{url}}}" id="{{id}}" class="{{classes}}" {{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}} {{/attributes}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</a>
+    <a href="{{{url}}}" id="{{id}}" class="{{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</a>
     {{#hasactions}}
         {{> core/actions }}
     {{/hasactions}}
 {{/disabled}}
 {{#disabled}}
-    <span class="currentlink {{classes}}" {{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}} {{/attributes}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</span>
+    <span class="currentlink {{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</span>
 {{/disabled}}
diff --git a/lib/templates/action_menu.mustache b/lib/templates/action_menu.mustache
index a6dc24377ab..bb1167ae3b8 100644
--- a/lib/templates/action_menu.mustache
+++ b/lib/templates/action_menu.mustache
@@ -30,10 +30,10 @@
         }
     }
 }}
-<div class="{{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+<div class="{{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
     {{#primary}}
 
-        <ul class="{{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+        <ul class="{{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
 
             {{#prioritise}}<li role="presentation">{{> core/action_menu_trigger }}</li>{{/prioritise}}<!--
 
@@ -46,7 +46,7 @@
     {{/primary}}
 
     {{#secondary}}
-        <ul class="{{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+        <ul class="{{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
             {{#items}}<li role="presentation">{{> core/action_menu_item }}</li>{{/items}}
         </ul>
     {{/secondary}}
diff --git a/lib/templates/action_menu_link.mustache b/lib/templates/action_menu_link.mustache
index 054df8b5302..d8d34627e54 100644
--- a/lib/templates/action_menu_link.mustache
+++ b/lib/templates/action_menu_link.mustache
@@ -29,7 +29,7 @@
     }
 }}
 {{^disabled}}
-    <a href="{{url}}" class="{{classes}}" {{#attributes}}{{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>
+    <a href="{{url}}" class="{{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>
 {{/disabled}}
 {{#disabled}}
     <span class="currentlink" role="menuitem">{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</span>
diff --git a/lib/templates/pix_icon.mustache b/lib/templates/pix_icon.mustache
index 403735c92a8..f2fcc5cb855 100644
--- a/lib/templates/pix_icon.mustache
+++ b/lib/templates/pix_icon.mustache
@@ -40,4 +40,4 @@
     }
 
 }}
-<img {{#attributes}}{{name}}="{{value}}" {{/attributes}}/>
\ No newline at end of file
+<img{{#attributes}} {{name}}="{{value}}"{{/attributes}}/>
\ No newline at end of file
diff --git a/lib/templates/select_time.mustache b/lib/templates/select_time.mustache
index e2954cdcf31..d14658a8d7e 100644
--- a/lib/templates/select_time.mustache
+++ b/lib/templates/select_time.mustache
@@ -31,7 +31,7 @@
     }
 }}
 <label for="{{id}}" class="accesshide">{{label}}</label>
-<select name="{{name}}" id="{{id}}" {{#attributes}} {{name}}="{{value}}"{{/attributes}}>
+<select name="{{name}}" id="{{id}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
     {{#options}}
         <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
     {{/options}}
diff --git a/lib/templates/single_select.mustache b/lib/templates/single_select.mustache
index 7d8831f7694..57eb5330a85 100644
--- a/lib/templates/single_select.mustache
+++ b/lib/templates/single_select.mustache
@@ -88,7 +88,7 @@
             <input type="hidden" name="{{name}}" value="{{value}}">
         {{/params}}
         {{#label}}
-            <label for="{{id}}" {{#labelattributes}}{{name}}="{{value}}" {{/labelattributes}}>
+            <label for="{{id}}"{{#labelattributes}} {{name}}="{{value}}"{{/labelattributes}}>
                 {{{label}}}
             </label>
         {{/label}}
diff --git a/lib/templates/url_select.mustache b/lib/templates/url_select.mustache
index 807b36a7f30..b2ace98c24c 100644
--- a/lib/templates/url_select.mustache
+++ b/lib/templates/url_select.mustache
@@ -27,7 +27,7 @@
         <input type="hidden" name="sesskey" value="{{sesskey}}">
         <div class="form-group">
             {{#label}}
-                <label for="{{id}}" {{#labelattributes}}{{name}}="{{value}}" {{/labelattributes}}>
+                <label for="{{id}}"{{#labelattributes}} {{name}}="{{value}}"{{/labelattributes}}>
                     {{label}}
                 </label>
             {{/label}}
diff --git a/theme/boost/templates/core/action_menu.mustache b/theme/boost/templates/core/action_menu.mustache
index 5a0d38f9e07..c09f5560d89 100644
--- a/theme/boost/templates/core/action_menu.mustache
+++ b/theme/boost/templates/core/action_menu.mustache
@@ -30,10 +30,10 @@
         }
     }
 }}
-<div class="action-menu {{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+<div class="action-menu {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
     {{#primary}}
 
-        <div class="{{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+        <div class="{{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
 
             {{#prioritise}}{{> core/action_menu_trigger }}{{/prioritise}}{{!
 
diff --git a/theme/boost/templates/core/action_menu_link.mustache b/theme/boost/templates/core/action_menu_link.mustache
index 756e95c77dd..34108f77f88 100644
--- a/theme/boost/templates/core/action_menu_link.mustache
+++ b/theme/boost/templates/core/action_menu_link.mustache
@@ -27,7 +27,7 @@
     }
 }}
 {{^disabled}}
-    <a href="{{url}}" class="{{classes}}" {{#attributes}}{{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>
+    <a href="{{url}}" class="{{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>
 {{/disabled}}
 {{#disabled}}
     <span class="currentlink" role="menuitem">{{#icon}}{{>core/pix_icon}}{{/icon}}{{{text}}}</span>
diff --git a/theme/boost/templates/core/action_menu_trigger.mustache b/theme/boost/templates/core/action_menu_trigger.mustache
index 39bc925263f..3bbde4b4428 100644
--- a/theme/boost/templates/core/action_menu_trigger.mustache
+++ b/theme/boost/templates/core/action_menu_trigger.mustache
@@ -20,9 +20,9 @@
 <span class="dropdown">
     <a href="#" class="dropdown-toggle" id="dropdown-{{instance}}" title="{{title}}" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">{{{actiontext}}}{{{menutrigger}}}{{#icon}}{{> core/pix_icon}}{{/icon}}{{#rawicon}}{{{.}}}{{/rawicon}}{{#menutrigger}}<b class="caret"></b>{{/menutrigger}}</a>
     {{#secondary}}
-        <div class="dropdown-menu dropdown-menu-right {{classes}}" {{#attributes}}{{name}}="{{value}}"{{/attributes}} aria-labelledby="dropdown-{{instance}}">
+        <span class="dropdown-menu dropdown-menu-right {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}} aria-labelledby="dropdown-{{instance}}">
             {{#items}}{{!
-                }}{{#actionmenulink}}<a href="{{url}}" class="dropdown-item {{classes}}" {{#attributes}}{{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>{{/actionmenulink}}{{!
+                }}{{#actionmenulink}}<a href="{{url}}" class="dropdown-item {{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>{{/actionmenulink}}{{!
                 }}{{#actionmenufiller}}<div class="dropdown-divider"></div>{{/actionmenufiller}}{{!
                 }}{{^actionmenulink}}{{^actionmenufiller}}<div class="dropdown-item">{{> core/action_menu_item }}</div>{{/actionmenufiller}}{{/actionmenulink}}{{!
             }}{{/items}}
diff --git a/theme/boost/templates/core/pix_icon.mustache b/theme/boost/templates/core/pix_icon.mustache
index fd62cd415e4..6b846fbe524 100644
--- a/theme/boost/templates/core/pix_icon.mustache
+++ b/theme/boost/templates/core/pix_icon.mustache
@@ -39,4 +39,4 @@
     }
 
 }}
-<img class="icon {{extraclasses}}" {{#attributes}}{{name}}="{{value}}" {{/attributes}}/>
+<img class="icon {{extraclasses}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}/>
diff --git a/theme/boost/templates/core/select_time.mustache b/theme/boost/templates/core/select_time.mustache
index 64932801369..f2c9029613e 100644
--- a/theme/boost/templates/core/select_time.mustache
+++ b/theme/boost/templates/core/select_time.mustache
@@ -31,7 +31,7 @@
     }
 }}
 <label for="{{id}}" class="sr-only">{{label}}</label>
-<select name="{{name}}" id="{{id}}" {{#attributes}} {{name}}="{{value}}"{{/attributes}} class="form-control">
+<select name="{{name}}" id="{{id}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}} class="form-control">
     {{#options}}
         <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
     {{/options}}

From c77cdbd7041de9f4f2a48e1bbc46e3748baf67a3 Mon Sep 17 00:00:00 2001
From: Cameron Ball <cameron@moodle.com>
Date: Fri, 16 Dec 2016 12:24:19 +0800
Subject: [PATCH 2/4] MDL-57321 theme_boost: Use div instead of span for
 dropdown items

---
 theme/boost/templates/core/action_menu_trigger.mustache | 6 +++---
 theme/boost/templates/core/custom_menu_item.mustache    | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/theme/boost/templates/core/action_menu_trigger.mustache b/theme/boost/templates/core/action_menu_trigger.mustache
index 3bbde4b4428..1726e4bb0a7 100644
--- a/theme/boost/templates/core/action_menu_trigger.mustache
+++ b/theme/boost/templates/core/action_menu_trigger.mustache
@@ -17,10 +17,10 @@
 {{!
     Action menu trigger.
 }}
-<span class="dropdown">
+<div class="dropdown">
     <a href="#" class="dropdown-toggle" id="dropdown-{{instance}}" title="{{title}}" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">{{{actiontext}}}{{{menutrigger}}}{{#icon}}{{> core/pix_icon}}{{/icon}}{{#rawicon}}{{{.}}}{{/rawicon}}{{#menutrigger}}<b class="caret"></b>{{/menutrigger}}</a>
     {{#secondary}}
-        <span class="dropdown-menu dropdown-menu-right {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}} aria-labelledby="dropdown-{{instance}}">
+        <div class="dropdown-menu dropdown-menu-right {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}} aria-labelledby="dropdown-{{instance}}">
             {{#items}}{{!
                 }}{{#actionmenulink}}<a href="{{url}}" class="dropdown-item {{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>{{/actionmenulink}}{{!
                 }}{{#actionmenufiller}}<div class="dropdown-divider"></div>{{/actionmenufiller}}{{!
@@ -28,4 +28,4 @@
             }}{{/items}}
         </div>
     {{/secondary}}
-</span>
+</div>
diff --git a/theme/boost/templates/core/custom_menu_item.mustache b/theme/boost/templates/core/custom_menu_item.mustache
index 9a35f5745a7..80760ead133 100644
--- a/theme/boost/templates/core/custom_menu_item.mustache
+++ b/theme/boost/templates/core/custom_menu_item.mustache
@@ -1,6 +1,6 @@
 {{^divider}}
 {{#haschildren}}
-<span class="dropdown nav-item">
+<div class="dropdown nav-item">
     <a class="dropdown-toggle nav-link" id="drop-down-{{uniqid}}" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" href="#">
         {{text}}
     </a>
@@ -14,7 +14,7 @@
             {{/divider}}
         {{/children}}
     </div>
-</span>
+</div>
 {{/haschildren}}
 {{^haschildren}}
 <a class="nav-item nav-link" href="{{{url}}}" {{#title}}title="{{{title}}}"{{/title}}>{{text}}</a>

From 32778e73dec724119beca0c9b2b4ff6981ea4729 Mon Sep 17 00:00:00 2001
From: Cameron Ball <cameron@moodle.com>
Date: Thu, 15 Dec 2016 12:43:25 +0800
Subject: [PATCH 3/4] MDL-57321 theme_boost: Fix improperly nested ul elements
 in footer

---
 theme/boost/templates/custom_menu_footer.mustache | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/theme/boost/templates/custom_menu_footer.mustache b/theme/boost/templates/custom_menu_footer.mustache
index e26a6d1544b..c03dd3fa1c4 100644
--- a/theme/boost/templates/custom_menu_footer.mustache
+++ b/theme/boost/templates/custom_menu_footer.mustache
@@ -8,8 +8,10 @@
             {{/url}}
         {{/divider}}
         {{#haschildren}}
-            <ul class="list-unstyled m-l-1">
-                {{> theme_boost/custom_menu_footer }}
-            </ul>
+            <li>
+                <ul class="list-unstyled m-l-1">
+                    {{> theme_boost/custom_menu_footer }}
+                </ul>
+            </li>
         {{/haschildren}}
     {{/children}}

From df21e24f265986454455b3bbde84e0a8b259d401 Mon Sep 17 00:00:00 2001
From: Cameron Ball <cameron@moodle.com>
Date: Fri, 16 Dec 2016 12:25:29 +0800
Subject: [PATCH 4/4] MDL-57321 theme_boost: Remove duplicate aria-labelledby
 attribute

---
 theme/boost/templates/core/action_menu_trigger.mustache | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/theme/boost/templates/core/action_menu_trigger.mustache b/theme/boost/templates/core/action_menu_trigger.mustache
index 1726e4bb0a7..ecc18e96f9c 100644
--- a/theme/boost/templates/core/action_menu_trigger.mustache
+++ b/theme/boost/templates/core/action_menu_trigger.mustache
@@ -18,9 +18,9 @@
     Action menu trigger.
 }}
 <div class="dropdown">
-    <a href="#" class="dropdown-toggle" id="dropdown-{{instance}}" title="{{title}}" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">{{{actiontext}}}{{{menutrigger}}}{{#icon}}{{> core/pix_icon}}{{/icon}}{{#rawicon}}{{{.}}}{{/rawicon}}{{#menutrigger}}<b class="caret"></b>{{/menutrigger}}</a>
+    <a href="#" class="dropdown-toggle" id="action-menu-toggle-{{instance}}" title="{{title}}" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">{{{actiontext}}}{{{menutrigger}}}{{#icon}}{{> core/pix_icon}}{{/icon}}{{#rawicon}}{{{.}}}{{/rawicon}}{{#menutrigger}}<b class="caret"></b>{{/menutrigger}}</a>
     {{#secondary}}
-        <div class="dropdown-menu dropdown-menu-right {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}} aria-labelledby="dropdown-{{instance}}">
+        <div class="dropdown-menu dropdown-menu-right {{classes}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}">
             {{#items}}{{!
                 }}{{#actionmenulink}}<a href="{{url}}" class="dropdown-item {{classes}}"{{#attributes}} {{name}}={{#quote}}{{value}}{{/quote}}{{/attributes}} {{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>{{#icon}}{{>core/pix_icon}}{{/icon}}{{#showtext}}<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>{{/showtext}}</a>{{/actionmenulink}}{{!
                 }}{{#actionmenufiller}}<div class="dropdown-divider"></div>{{/actionmenufiller}}{{!