From 43c8e1f5961bb32aaf03ed9b2bf56e8d23672cd5 Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Thu, 14 Jun 2018 11:53:17 +0800 Subject: [PATCH] MDL-62643 assign: Skip empty online text files Online text assignment submissions with no text entered into the editor should not create a blank html document for providing feedback. --- mod/assign/submission/onlinetext/locallib.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mod/assign/submission/onlinetext/locallib.php b/mod/assign/submission/onlinetext/locallib.php index 85ea4dc3314..f9018e29a90 100644 --- a/mod/assign/submission/onlinetext/locallib.php +++ b/mod/assign/submission/onlinetext/locallib.php @@ -395,7 +395,9 @@ class assign_submission_onlinetext extends assign_submission_plugin { $files = array(); $onlinetextsubmission = $this->get_onlinetext_submission($submission->id); - if ($onlinetextsubmission) { + // Note that this check is the same logic as the result from the is_empty function but we do + // not call it directly because we already have the submission record. + if ($onlinetextsubmission && !empty($onlinetextsubmission->onlinetext)) { $finaltext = $this->assignment->download_rewrite_pluginfile_urls($onlinetextsubmission->onlinetext, $user, $this); $formattedtext = format_text($finaltext, $onlinetextsubmission->onlineformat,