mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

MDL-82895 qbank_managecategories: Correct dnd hover text encoding

Browse Source
This commit is contained in:
Luca Bösch 2024-08-26 16:50:26 +02:00
parent c58bc49a07
commit bcf2d4d224
4 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
question/bank/managecategories/classes/output/category.php
View File

@ -90,7 +90,7 @@ class category implements renderable, templatable {
// Each section adds html to be displayed as part of this list item.
$questionbankurl = new moodle_url('/question/edit.php', $params);
$questionbankurl->param('cat', helper::combine_id_context($this->category));
$categoryname = format_string($this->category->name, true, ['context' => $this->context]);
$categoryname = format_string($this->category->name, true, ['context' => $this->context, 'escape' => false]);
$idnumber = null;
if ($this->category->idnumber !== null && $this->category->idnumber !== '') {
$idnumber = $this->category->idnumber;

6
question/bank/managecategories/templates/category.mustache
View File

@ -22,10 +22,10 @@
Context variables required for this template:
* categoryid - The id of the category this item represents.
* questionbankurl - Url for corresponding question bank.
* categoryname - Category name.
* categoryname - Category name. Raw string. Will be HTML-escaped during rendering.
* idnumber - Id number string (optional).
* questioncount - Number of question in question bank.
* categorydesc - Category description.
* categorydesc - Category description. HTML that is safe to output (e.g. from format_text).
* editactionmenu - Edit action menu link.
* draghandle - Boolean if handle should be displayed (if category is movable).
* children - Children category item to curent category (same variables as those above).
@ -34,7 +34,7 @@
{
"categoryid": "1",
"questionbankurl": "question/edit.php?cmid=123",
"categoryname": "Default for Miscellaneous",
"categoryname": "Default for Miscellaneous & < > \" '",
"idnumber": "1",
"questioncount": " 1",
"categorydesc": "The default category for questions shared in context Miscellaneous",

8
question/bank/managecategories/templates/category_details.mustache
View File

@ -22,10 +22,10 @@
Context variables required for this template:
* categoryid - The id of the category this item represents.
* questionbankurl - Url for corresponding question bank.
* categoryname - Category name.
* categoryname - Category name. Raw string. Will be HTML-escaped during rendering.
* idnumber - Id number string (optional).
* questioncount - Number of question in question bank.
* categorydesc - Category description.
* categorydesc - Category description. HTML that is safe to output (e.g. from format_text).
* editactionmenu - Edit action menu link.
* draghandle - Boolean if handle should be displayed (if category is movable).
* children - Children category item to curent category (same variables as those above).
@ -34,7 +34,7 @@
{
"categoryid": "1",
"questionbankurl": "question/edit.php?cmid=123",
"categoryname": "Default for Miscellaneous",
"categoryname": "Default for Miscellaneous & < > \" '",
"idnumber": "1",
"questioncount": " 1",
"categorydesc": "The default category for questions shared in context Miscellaneous",
@ -44,7 +44,7 @@
}}
<strong>
<a title="{{#str}}editquestions, question{{/str}}" href="{{{questionbankurl}}}" role="button">
{{{categoryname}}}
{{categoryname}}
{{#idnumber}}
<span class="badge badge-primary">
<span class="accesshide">

26
question/bank/managecategories/tests/behat/question_categories.feature
View File

@ -15,13 +15,13 @@ Feature: A teacher can put questions in categories in the question bank
| user | course | role |
| teacher1 | C1 | editingteacher |
And the following "question categories" exist:
| contextlevel | reference | questioncategory | name | sortorder | desciption |
| Course | C1 | Top | top | 0 | |
| Course | C1 | top | Default for C1 | 0 | Description for default for C1 |
| Course | C1 | Default for C1 | Subcategory | 0 | Description for Subcategory |
| Course | C1 | Default for C1 | Another subcat | 1 | Description for Another subcat |
| Course | C1 | top | Used category | 1 | |
| Course | C1 | top | Default & testing | 2 | |
| contextlevel | reference | questioncategory | name | sortorder | desciption |
| Course | C1 | Top | top | 0 | |
| Course | C1 | top | Default for C1 | 0 | Description for default for C1 |
| Course | C1 | Default for C1 | Subcategory & < > " ' &amp; | 0 | Description for Subcategory & < > " ' &amp; |
| Course | C1 | Default for C1 | Another subcat | 1 | Description for Another subcat |
| Course | C1 | top | Used category | 1 | |
| Course | C1 | top | Default & testing | 2 | |
And the following "questions" exist:
| questioncategory | qtype | name | questiontext |
| Used category | essay | Test question to be moved | Write about whatever you want |
@ -50,9 +50,9 @@ Feature: A teacher can put questions in categories in the question bank
When I am on the "Course 1" "core_question > course question categories" page
# There have been bugs which only happened if a question category was not empty, so add a question.
And the following "questions" exist:
| questioncategory | qtype | name | questiontext |
| Subcategory | essay | Test question for renaming category | Write about whatever you want |
And I open the action menu in "Subcategory" "list_item"
| questioncategory | qtype | name | questiontext |
| Subcategory & < > " ' &amp; | essay | Test question for renaming category | Write about whatever you want |
And I open the action menu in "Subcategory & < > \" ' &amp;" "list_item"
And I choose "Edit settings" in the open action menu
And the field "parent" matches value "&nbsp;&nbsp;&nbsp;Default for C1"
And I set the following fields to these values:
@ -65,10 +65,12 @@ Feature: A teacher can put questions in categories in the question bank
Scenario: An empty question category can be deleted
When I am on the "Course 1" "core_question > course question categories" page
And I open the action menu in "Subcategory" "list_item"
And I should see "Subcategory & < > \" ' &amp;"
And the "title" attribute of "span.qbank_managecategories-newchild.dropready" "css_element" should contain "As new child of Subcategory & < > \" ' &amp;"
And I open the action menu in "Subcategory & < > \" ' &amp;" "list_item"
And I choose "Delete" in the open action menu
And I click on "Delete" "button" in the "Delete" "dialogue"
Then I should not see "Subcategory"
Then I should not see "Subcategory & < > \" ' &amp;"
Scenario: An non-empty question category can be deleted if you move the contents elsewhere
When I am on the "Course 1" "core_question > course question categories" page