mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-04 16:04:00 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77430 plugininfo: php81 deprecation warnings on missing plugins

Browse Source 
Whenever some plugin is missing from disk but installed, the plugins
page (and the upgrade) shows them as "missing from disk". Still, the
code tries to do things with their directory that, now, is null.

That was silently defaulting to '' in previous php versions, but
php81 emits a deprecated warning. So we have to check for them.
This commit is contained in:
Eloy Lafuente (stronk7) 2023-02-28 11:34:21 +01:00
parent a31f5830bd
commit be32856374
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/classes/plugin_manager.php
View File

@ -1651,7 +1651,7 @@ class core_plugin_manager {
}
// To be able to remove the plugin folder, its parent must be writable, too.
if (!is_writable(dirname($pluginfo->rootdir))) {
if (!isset($pluginfo->rootdir) || !is_writable(dirname($pluginfo->rootdir))) {
return false;
}

4
lib/classes/plugininfo/base.php
View File

@ -598,6 +598,10 @@ abstract class base {
public function get_dir() {
global $CFG;
if (!isset($pluginfo->rootdir)) {
return '';
}
return substr($this->rootdir, strlen($CFG->dirroot));
}