diff --git a/.upgradenotes/MDL-81509-2024092613384220.yml b/.upgradenotes/MDL-81509-2024092613384220.yml new file mode 100644 index 00000000000..57daacc5a33 --- /dev/null +++ b/.upgradenotes/MDL-81509-2024092613384220.yml @@ -0,0 +1,7 @@ +issueNumber: MDL-81509 +notes: + core: + - message: >- + Final deprecation of methods task_base::is_blocking and + task_base::set_blocking. + type: removed diff --git a/lib/classes/task/task_base.php b/lib/classes/task/task_base.php index 8253389ef88..68f161910cb 100644 --- a/lib/classes/task/task_base.php +++ b/lib/classes/task/task_base.php @@ -116,39 +116,31 @@ abstract class task_base { } /** - * Setter for $blocking. - * - * Please note that task blocking is no longer supported. - * If you are using it in older versions of Moodle you are strongly advised to rewrite your code - * as has a detrimental impact upon performance. - * * @deprecated since Moodle 4.4 See MDL-67667 - * @todo Remove in MDL-81509 */ #[\core\attribute\deprecated( replacement: null, since: '4.4', + mdl: 'MDL-67667', reason: 'Blocking tasks are no longer supported', + final: true, )] - public function set_blocking($blocking) { + public function set_blocking() { \core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]); } /** - * Getter for $blocking. - * - * @return bool * @deprecated since Moodle 4.4 See MDL-67667 - * @todo Remove in MDL-81509 */ #[\core\attribute\deprecated( replacement: null, since: '4.4', + mdl: 'MDL-67667', reason: 'Blocking tasks are no longer supported', + final: true, )] public function is_blocking() { \core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]); - return false; } /**