mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-05 00:12:42 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77896 editor_tiny: approximate height for non-visible editors.

Browse Source 
When an editor is renderer initially invisible to the browser, e.g.
the forum "Add discussion" form, it has a `clientHeight` value of
zero. We can approximate an alternative value based on the number
of rows in the textarea.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
This commit is contained in:
Paul Holden 2023-04-19 16:34:00 +01:00
parent 38c35247e9
commit c28cd3215b
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/editor/tiny/amd/build/editor.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
lib/editor/tiny/amd/build/editor.min.js.map
View File

File diff suppressed because one or more lines are too long

6
lib/editor/tiny/amd/src/editor.js
View File

@ -213,8 +213,10 @@ const getStandardConfig = (target, tinyMCE, options, plugins) => {
// Set the minimum height to the smallest height that we can fit the Menu bar, Tool bar, Status bar and the text area.
// eslint-disable-next-line camelcase
min_height: 175,
// Base the height on the size of the text area.
height: target.clientHeight,
// Base the height on the size of the text area. Account for lack of height value when the editor is initially hidden,
// in which case use CSS calc() to approximate the same based on number of rows and target line height.
height: target.clientHeight || `calc(${target.rows} * ${window.getComputedStyle(target).lineHeight || '22px'})`,
// Set the language.
// https://www.tiny.cloud/docs/tinymce/6/ui-localization/#language