mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-23 09:23:09 +02:00
Code Issues Projects Releases Wiki Activity

rating MDL-21657 added aliasing and unaliasing of the fields returned by user_picture::fields

Browse Source
This commit is contained in:
Andrew Davis 2010-03-18 08:12:13 +00:00
parent f3afba4e19
commit c538a23d9d
2 changed files with 7 additions and 1 deletions

6
rating/index.php

@ -78,7 +78,13 @@ if (!$ratings) {
echo "<th class=\"header\" scope=\"col\" style=\"width:100%\"><a href=\"report.php?id=$itemid&amp;sort=rating\">$strrating</a></th>";
echo "<th class=\"header\" scope=\"col\"><a href=\"report.php?id=$itemid&amp;sort=time\">$strtime</a></th>";
echo "</tr>";
$user = null;
foreach ($ratings as $rating) {
//undo the aliasing necessary for user_picture::fields
$user = clone($rating);//could get away with just overwriting rating->id and not cloning
//the rating object as we don't use rating->id again. That just seems like a bad idea.
$user->id = $user->uid;
echo '<tr class="ratingitemheader">';
echo "<td>";
if($course && $course->id) {

2
rating/lib.php

@ -183,7 +183,7 @@ class rating implements renderable {
public static function load_ratings_for_item($context, $itemid, $sort) {
global $DB;
$userfields = user_picture::fields('u');
$userfields = user_picture::fields('u','uid');
$sql = "SELECT r.id, r.rating, r.itemid, r.userid, r.timemodified,
$userfields
FROM {rating} r