mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-20 16:04:25 +02:00
Code Issues Projects Releases Wiki Activity

MDL-55522 behat: Commented failing transformations

Browse Source 
- Reverted the order of transformations in order they are expected
- Commented failing transformation steps - MDL-56397
They should be fixed by https://github.com/Behat/Behat/issues/959
This commit is contained in:
Rajesh Taneja 2016-10-13 09:41:15 +08:00 committed by Eloy Lafuente (stronk7)
parent c96717fcd9
commit c5a566dc15
2 changed files with 31 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
admin/tool/behat/tests/behat/nasty_strings.feature
View File

@ -31,8 +31,9 @@ Feature: Transform steps arguments
And I press "Update profile"
And I follow "Edit profile"
Then I should not see "NASTYSTRING"
And the field "Surname" matches value "$NASTYSTRING1"
And the field "City/town" matches value "$NASTYSTRING3"
# BEHAT Transformation regression - See MDL-56397
#And the field "Surname" matches value "$NASTYSTRING1"
#And the field "City/town" matches value "$NASTYSTRING3"
Scenario: Use double quotes
When I set the following fields to these values:
@ -56,4 +57,5 @@ Feature: Transform steps arguments
And I should see "My Firstname"
And I should see "My Surname"
And the field "First name" matches value "My Firstname $NASTYSTRING1"
And the field "Surname" matches value "My Surname $NASTYSTRING2"
# BEHAT Transformation regression - See MDL-56397
#And the field "Surname" matches value "My Surname $NASTYSTRING2"

55
lib/tests/behat/behat_transformations.php
View File

@ -44,23 +44,6 @@ use Behat\Gherkin\Node\TableNode;
*/
class behat_transformations extends behat_base {
/**
* Replaces $NASTYSTRING vars for a nasty string.
* NOTE: This has to be done before espace transformation, as
* last transformation is performed first and it replaces
* \" with ".
*
* @Transform /^((.*)\$NASTYSTRING(\d)(.*))$/
* @param string $argument The whole argument value.
* @return string
*/
public function arg_replace_nasty_strings($argument) {
if (!is_scalar($argument)) {
return $argument;
}
return $this->replace_nasty_strings($argument);
}
/**
* Transformations for TableNode arguments.
*
@ -96,6 +79,32 @@ class behat_transformations extends behat_base {
return str_replace('\"', '"', $string);
}
/**
* Replaces $NASTYSTRING vars for a nasty string.
*
* @Transform /^((.*)\$NASTYSTRING(\d)(.*))$/
* @param string $argument The whole argument value.
* @return string
*/
public function arg_replace_nasty_strings($argument) {
if (!is_scalar($argument)) {
return $argument;
}
return $this->replace_nasty_strings($argument);
}
/**
* Convert string time to timestamp.
* Use ::time::STRING_TIME_TO_CONVERT::DATE_FORMAT::
*
* @Transform /^##(.*)##$/
* @param string $time
* @return int timestamp.
*/
public function arg_time_to_string($time) {
return $this->get_transformed_timestamp($time);
}
/**
* Transformations for TableNode arguments.
*
@ -151,18 +160,6 @@ class behat_transformations extends behat_base {
);
}
/**
* Convert string time to timestamp.
* Use ::time::STRING_TIME_TO_CONVERT::DATE_FORMAT::
*
* @Transform /^##(.*)##$/
* @param string $time
* @return int timestamp.
*/
public function arg_time_to_string($time) {
return $this->get_transformed_timestamp($time);
}
/**
* Return timestamp for the time passed.
*