From c5c065e10a8f5fbb40b72ab932f9802a9ce60445 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Thu, 30 Mar 2023 22:50:13 +0800 Subject: [PATCH] MDL-77306 core: Remove LIMIT from SQL statement Adding LIMIT to the primary auth type SQL statement does not play well with Oracle. We can just remove the LIMIT clause from the SQL statement and and pass IGNORE_MULTIPLE to the call to $DB->get_field_sql() instead. --- lib/classes/hub/registration.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/classes/hub/registration.php b/lib/classes/hub/registration.php index 0a07cfafb9a..1650fc8b505 100644 --- a/lib/classes/hub/registration.php +++ b/lib/classes/hub/registration.php @@ -185,9 +185,10 @@ class registration { $siteinfo['dbtype'] = $CFG->dbtype; $siteinfo['coursesnodates'] = $DB->count_records_select('course', 'startdate = ? AND enddate = ?', [0, 0]) - 1; $siteinfo['sitetheme'] = get_config('core', 'theme'); - $siteinfo['primaryauthtype'] = $DB->get_field_sql( - 'SELECT auth, count(auth) as tc FROM {user} GROUP BY auth ORDER BY tc DESC LIMIT 1' - ); + + // Primary auth type. + $primaryauthsql = 'SELECT auth, count(auth) as tc FROM {user} GROUP BY auth ORDER BY tc DESC'; + $siteinfo['primaryauthtype'] = $DB->get_field_sql($primaryauthsql, null, IGNORE_MULTIPLE); // Version and url. $siteinfo['moodlerelease'] = $CFG->release;