mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-63620 group: Option to enable group messaging for imported groups

Browse Source
This commit is contained in:
Jun Pataleta 2019-01-14 13:31:23 +08:00
parent e5e5b37749
commit c617a7271a
3 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
group/import.php
View File

@ -83,7 +83,9 @@ if ($mform_post->is_cancelled()) {
"groupidnumber" => 1,
"description" => 1,
"enrolmentkey" => 1,
"groupingname" => 1);
"groupingname" => 1,
"enablemessaging" => 1,
);
// --- get header (field names) ---
$header = explode($csv_delimiter, array_shift($rawlines));

11
group/tests/behat/groups_import.feature
View File

@ -31,6 +31,17 @@ Feature: Importing of groups and groupings
And I should see "group-id-1-duplicate"
And I should see "group-noid-1"
And I should see "group-noid-2"
# Group messaging should have been enabled for group-id-1.
And I set the field "groups" to "group-id-1"
And I press "Edit group settings"
And I should see "Yes" in the "Group messaging" "select"
And I press "Cancel"
# Group messaging should not have been enabled for group-id-2.
And I set the field "groups" to "group-id-2"
And I press "Edit group settings"
And I should see "No" in the "Group messaging" "select"
And I press "Cancel"
# Check groupings
And I follow "Groupings"
And I should see "Grouping-1"
And I should see "Grouping-2"

12
group/tests/fixtures/groups_import.csv vendored
View File

@ -1,6 +1,6 @@
groupname, description, groupidnumber,groupingname
group-id-1, group-id-1, group-id-1,Grouping-1
group-id-2, group-id-2, group-id-2,Grouping-2
group-id-1-duplicate, Duplicate of group-id-1, group-id-1,Grouping-3
group-noid-1, group-noid-1,,Grouping-3
group-noid-2, group-noid-2,,Grouping-2
groupname, description, groupidnumber,groupingname,enablemessaging
group-id-1, group-id-1, group-id-1,Grouping-1,1
group-id-2, group-id-2, group-id-2,Grouping-2,0
group-id-1-duplicate, Duplicate of group-id-1, group-id-1,Grouping-3,0
group-noid-1, group-noid-1,,Grouping-3,0
group-noid-2, group-noid-2,,Grouping-2,0

1 groupname description groupidnumber groupingname enablemessaging
2 group-id-1 group-id-1 group-id-1 Grouping-1 1
3 group-id-2 group-id-2 group-id-2 Grouping-2 0
4 group-id-1-duplicate Duplicate of group-id-1 group-id-1 Grouping-3 0
5 group-noid-1 group-noid-1 Grouping-3 0
6 group-noid-2 group-noid-2 Grouping-2 0