mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-82503 badges: Deprecate showmanage button from action_bar

Browse Source
This commit is contained in:
Sara Arjona 2024-08-14 13:59:34 +02:00
parent 6adbe05d9f
commit c6d7cf85f6
No known key found for this signature in database
3 changed files with 31 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.upgradenotes/MDL-82503-2024081605172847.yml Normal file
View File

@ -0,0 +1,7 @@
issueNumber: MDL-82503
notes:
core_badges:
- message: >-
The $showmanage parameter in the core_badges\output\standard_action_bar
constructor has been deprecated and should not be used anymore.
type: deprecated

7
badges/award.php
View File

@ -84,7 +84,12 @@ if (!$badge->is_active()) {
$returnurl = new moodle_url('recipients.php', array('id' => $badge->id));
$returnlink = html_writer::link($returnurl, $strrecipients);
$actionbar = new \core_badges\output\standard_action_bar($PAGE, $badge->type, false, false, $returnurl);
$actionbar = new \core_badges\output\standard_action_bar(
page: $PAGE,
type: $badge->type,
showaddbadge: false,
backurl: $returnurl
);
$output = $PAGE->get_renderer('core', 'badges');
$tertiarynav = $output->render_tertiary_navigation($actionbar);

41
badges/classes/output/standard_action_bar.php
View File

@ -29,29 +29,29 @@ use single_button;
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class standard_action_bar extends base_action_bar {
/** @var bool $showmanage Whether or not to show the manage badges button. */
protected $showmanage;
/** @var bool $showaddbadge Whether or not to show the add badges button. */
protected $showaddbadge;
/** @var moodle_url $backurl BackURL to be used when the back button is required. */
protected $backurl;
/**
* standard_action_bar constructor
* The constructor.
*
* @param moodle_page $page The page object
* @param int $type The type of badge we are operating with
* @param bool $showmanage Whether or not to show the manage badges button
* @param bool $showaddbadge Whether or not to show the add badges button
* @param moodle_url|null $backurl The backurl to be used
*/
public function __construct(moodle_page $page, int $type, bool $showmanage = true,
$showaddbadge = true, ?moodle_url $backurl = null) {
public function __construct(
moodle_page $page,
int $type,
/** @var null|bool $showmanage This parameter has been deprecated since 4.5 and should not be used anymore. */
?bool $showmanage = null,
/** @var bool $showaddbadge Whether or not to show the add badges button. */
protected bool $showaddbadge = true,
/** @var moodle_url $backurl BackURL to be used when the back button is required. */
protected ?moodle_url $backurl = null,
) {
parent::__construct($page, $type);
$this->showmanage = $showmanage;
if ($showmanage !== null) {
debugging(
'The showmanage argument has been deprecated. Please remove it from your method calls.',
DEBUG_DEVELOPER,
);
}
$this->showaddbadge = $showaddbadge;
$this->backurl = $backurl;
}
@ -82,11 +82,6 @@ class standard_action_bar extends base_action_bar {
$params['id'] = $this->page->context->instanceid;
}
if ($this->showmanage) {
$buttons[] = new single_button(new moodle_url('/badges/index.php', $params),
get_string('managebadges', 'core_badges'), 'get');
}
if ($this->showaddbadge && has_capability('moodle/badges:createbadge', $this->page->context)) {
$editparams = ['action' => 'new'];
if (array_key_exists('id', $params)) {