mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-14679 detect incorrect key=>value pairs in $conditions - in case somebody forgets "=>" and uses "," instead

Browse Source
This commit is contained in:
skodak 2008-05-30 16:56:43 +00:00
parent d251907c51
commit c74a123781
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/dml/moodle_database.php
View File

@ -1187,6 +1187,11 @@ abstract class moodle_database {
*/
public abstract function sql_substr();
/**
* Returns SQL WHERE conditions
* @param array conditions - must not contain numeric indexes
* @return array sql part and params
*/
public function where_clause(array $conditions=null) {
$allowed_types = $this->allowed_param_types();
if (empty($conditions)) {
@ -1195,6 +1200,9 @@ abstract class moodle_database {
$where = array();
$params = array();
foreach ($conditions as $key=>$value) {
if (is_int($key)) {
error('$conditions array may not contain numeric keys, please fix the code!');
}
if (is_null($value)) {
$where[] = "$key IS NULL";
} else {