mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

Merge branch 'MDL-82499-MOODLE_404_STABLE' of https://github.com/micaherne/moodle into MOODLE_404_STABLE

Browse Source
This commit is contained in:
Ilya Tregubov 2024-07-22 09:42:53 +08:00
commit c930111e17
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/questionlib.php
View File

@ -1465,7 +1465,7 @@ function question_has_capability_on($questionorid, $cap, $notused = -1): bool {
WHERE q.id = :id';
// Well, at least we tried. Seems that we really have to read from DB.
$question = $DB->get_record_sql($sql, ['id' => $questionid]);
$question = $DB->get_record_sql($sql, ['id' => $questionid], MUST_EXIST);
}
}

15
lib/tests/questionlib_test.php
View File

@ -2008,6 +2008,21 @@ class questionlib_test extends \advanced_testcase {
question_has_capability_on('one', 'tag');
}
/**
* Test question_has_capability_on with an invalid question ID
*/
public function test_question_has_capability_on_invalid_question(): void {
try {
question_has_capability_on(42, 'tag');
$this->fail('Expected exception');
} catch (\moodle_exception $exception) {
$this->assertInstanceOf(\dml_missing_record_exception::class, $exception);
// We also get debugging from initial attempt to load question data.
$this->assertDebuggingCalled();
}
}
/**
* Test of question_categorylist function.
*