From ea191cf1b4ae633b743e42b0b8acc5773371fc04 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Mon, 10 Dec 2018 17:03:50 +1100 Subject: [PATCH] MDL-41507 core_group: Consistent default value for FEATURE_GROUPS --- course/lib.php | 2 +- course/moodleform_mod.php | 2 +- lib/modinfolib.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/course/lib.php b/course/lib.php index dbb227dc6df..5f130362bb4 100644 --- a/course/lib.php +++ b/course/lib.php @@ -2003,7 +2003,7 @@ function course_get_cm_edit_actions(cm_info $mod, $indent = -1, $sr = null) { // Groupmode. if ($hasmanageactivities && !$mod->coursegroupmodeforce) { - if (plugin_supports('mod', $mod->modname, FEATURE_GROUPS, 0)) { + if (plugin_supports('mod', $mod->modname, FEATURE_GROUPS, false)) { if ($mod->effectivegroupmode == SEPARATEGROUPS) { $nextgroupmode = VISIBLEGROUPS; $grouptitle = $str->groupsseparate; diff --git a/course/moodleform_mod.php b/course/moodleform_mod.php index a3235ce1e00..5b47c51090e 100644 --- a/course/moodleform_mod.php +++ b/course/moodleform_mod.php @@ -170,7 +170,7 @@ abstract class moodleform_mod extends moodleform { global $CFG; $this->_features = new stdClass(); - $this->_features->groups = plugin_supports('mod', $this->_modname, FEATURE_GROUPS, true); + $this->_features->groups = plugin_supports('mod', $this->_modname, FEATURE_GROUPS, false); $this->_features->groupings = plugin_supports('mod', $this->_modname, FEATURE_GROUPINGS, false); $this->_features->outcomes = (!empty($CFG->enableoutcomes) and plugin_supports('mod', $this->_modname, FEATURE_GRADE_OUTCOMES, true)); $this->_features->hasgrades = plugin_supports('mod', $this->_modname, FEATURE_GRADE_HAS_GRADE, false); diff --git a/lib/modinfolib.php b/lib/modinfolib.php index 8541eab51d1..1e854e2a0c1 100644 --- a/lib/modinfolib.php +++ b/lib/modinfolib.php @@ -1575,7 +1575,7 @@ class cm_info implements IteratorAggregate { $groupmode = $this->groupmode; if ($this->modinfo->get_course()->groupmodeforce) { $groupmode = $this->modinfo->get_course()->groupmode; - if ($groupmode != NOGROUPS && !plugin_supports('mod', $this->modname, FEATURE_GROUPS, 0)) { + if ($groupmode != NOGROUPS && !plugin_supports('mod', $this->modname, FEATURE_GROUPS, false)) { $groupmode = NOGROUPS; } }