mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-17 14:35:29 +02:00
Code Issues Projects Releases Wiki Activity

MDL-23616 extremely messy hack to work around weird course handling resulting in unknown PAGE->context

Browse Source
This commit is contained in:
Petr Skoda 2010-08-04 07:37:02 +00:00
parent 44388c41f5
commit ca74470c8d
5 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
calendar/delete.php
View File

@ -50,10 +50,11 @@ $event = calendar_event::load($eventid);
*/
if ($event->eventtype !== 'user' && $event->eventtype !== 'site') {
$courseid = $event->courseid;
$course = $DB->get_record('course', array('id'=>$courseid), '*', MUST_EXIST);
require_login($course);
} else {
require_login();
}
$course = $DB->get_record('course', array('id'=>$courseid));
require_login($course);
if (!$course) {
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
}
// Check the user has the required capabilities to edit an event

5
calendar/export.php
View File

@ -79,7 +79,10 @@ if ($course !== NULL) {
}
$PAGE->set_url($url);
require_login();
require_login($course);
if (!$course) {
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
}
if (empty($CFG->enablecalendarexport)) {
die('no export');

1
calendar/preferences.php
View File

@ -17,6 +17,7 @@ if ($course->id != SITEID) {
require_login($course);
} else {
require_login();
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
}
// Initialize the session variables
calendar_session_vars();

1
calendar/set.php
View File

@ -70,6 +70,7 @@ if ($type !== 0) {
$url->param('type', $type);
}
$PAGE->set_url($url);
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
// Initialize the session variables
calendar_session_vars();

8
calendar/view.php
View File

@ -70,11 +70,15 @@ if ($yr !== 0) {
}
$PAGE->set_url($url);
//TODO: the courseid handling in /calendar/ is a bloody mess!!!
if ($courseid && $courseid != SITEID) {
require_login($courseid);
} else if ($CFG->forcelogin) {
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM));
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
require_login();
} else {
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM)); //TODO: wrong
}
$calendar = new calendar_information($day, $mon, $yr);
@ -140,7 +144,7 @@ if (!isloggedin() or isguestuser()) {
// but NOT for the "main page" course
if ($SESSION->cal_course_referer != SITEID &&
($shortname = $DB->get_field('course', 'shortname', array('id'=>$SESSION->cal_course_referer))) !== false) {
require_login();
require_login(); //TODO: very wrong!!
if (empty($course)) {
$course = $DB->get_record('course', array('id'=>$SESSION->cal_course_referer)); // Useful to have around
}