MDL-78849 user: correct logical operator behaviour for guest button.

Apart from being banned per MDL-74990, it causes a subtle bug here
due to operator precedence.

Co-authored-by: Tom Mayfield <tmayfield@costrack.com>
This commit is contained in:
Paul Holden 2023-11-16 11:24:52 +00:00
parent 935c2509f1
commit ca991dbe29
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164

View File

@ -90,7 +90,7 @@ class login implements renderable, templatable {
$languagedata = new \core\output\language_menu($PAGE);
$this->languagemenu = $languagedata->export_for_action_menu($OUTPUT);
$this->canloginasguest = $CFG->guestloginbutton and !isguestuser();
$this->canloginasguest = $CFG->guestloginbutton && !isguestuser();
$this->canloginbyemail = !empty($CFG->authloginviaemail);
$this->cansignup = $CFG->registerauth == 'email' || !empty($CFG->registerauth);
if ($CFG->rememberusername == 0) {